Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: components/security_state/security_state_model.cc

Issue 2481743009: Expose malware/phishing/etc. distinction from SafeBrowsingUIManager (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model.cc
diff --git a/components/security_state/security_state_model.cc b/components/security_state/security_state_model.cc
index 6d4094e1bdea2ef067a584604a171cc3aa9af903..464efa9531c6643e43a12c3b561e010acbb31507 100644
--- a/components/security_state/security_state_model.cc
+++ b/components/security_state/security_state_model.cc
@@ -125,12 +125,15 @@ SecurityStateModel::SecurityLevel GetSecurityLevelForRequest(
SecurityStateModel::ContentStatus mixed_content_status,
SecurityStateModel::ContentStatus content_with_cert_errors_status) {
DCHECK(visible_security_state.connection_info_initialized ||
- visible_security_state.fails_malware_check);
+ visible_security_state.malicious_content_status !=
+ SecurityStateModel::MALICIOUS_CONTENT_STATUS_NONE);
// Override the connection security information if the website failed the
// browser's malware checks.
- if (visible_security_state.fails_malware_check)
+ if (visible_security_state.malicious_content_status !=
+ SecurityStateModel::MALICIOUS_CONTENT_STATUS_NONE) {
return SecurityStateModel::DANGEROUS;
+ }
GURL url = visible_security_state.url;
@@ -208,9 +211,10 @@ void SecurityInfoForRequest(
SecurityStateModel::SecurityInfo* security_info) {
if (!visible_security_state.connection_info_initialized) {
*security_info = SecurityStateModel::SecurityInfo();
- security_info->fails_malware_check =
- visible_security_state.fails_malware_check;
- if (security_info->fails_malware_check) {
+ security_info->malicious_content_status =
+ visible_security_state.malicious_content_status;
+ if (security_info->malicious_content_status !=
+ SecurityStateModel::MALICIOUS_CONTENT_STATUS_NONE) {
security_info->security_level = GetSecurityLevelForRequest(
visible_security_state, client, SecurityStateModel::UNKNOWN_SHA1,
SecurityStateModel::CONTENT_STATUS_UNKNOWN,
@@ -239,8 +243,8 @@ void SecurityInfoForRequest(
security_info->sct_verify_statuses =
visible_security_state.sct_verify_statuses;
- security_info->fails_malware_check =
- visible_security_state.fails_malware_check;
+ security_info->malicious_content_status =
+ visible_security_state.malicious_content_status;
security_info->displayed_password_field_on_http =
visible_security_state.displayed_password_field_on_http;
@@ -264,7 +268,8 @@ const SecurityStateModel::SecurityLevel
SecurityStateModel::SecurityInfo::SecurityInfo()
: security_level(SecurityStateModel::NONE),
- fails_malware_check(false),
+ malicious_content_status(
+ SecurityStateModel::MALICIOUS_CONTENT_STATUS_NONE),
sha1_deprecation_status(SecurityStateModel::NO_DEPRECATED_SHA1),
mixed_content_status(SecurityStateModel::CONTENT_STATUS_NONE),
content_with_cert_errors_status(SecurityStateModel::CONTENT_STATUS_NONE),
@@ -296,7 +301,8 @@ void SecurityStateModel::SetClient(SecurityStateModelClient* client) {
}
SecurityStateModel::VisibleSecurityState::VisibleSecurityState()
- : fails_malware_check(false),
+ : malicious_content_status(
+ SecurityStateModel::MALICIOUS_CONTENT_STATUS_NONE),
connection_info_initialized(false),
cert_status(0),
connection_status(0),
@@ -315,7 +321,7 @@ SecurityStateModel::VisibleSecurityState::~VisibleSecurityState() {}
bool SecurityStateModel::VisibleSecurityState::operator==(
const SecurityStateModel::VisibleSecurityState& other) const {
return (url == other.url &&
- fails_malware_check == other.fails_malware_check &&
+ malicious_content_status == other.malicious_content_status &&
!!certificate == !!other.certificate &&
(certificate ? certificate->Equals(other.certificate.get()) : true) &&
connection_status == other.connection_status &&
« no previous file with comments | « components/security_state/security_state_model.h ('k') | components/security_state/security_state_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698