Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2254)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.cc

Issue 2481743009: Expose malware/phishing/etc. distinction from SafeBrowsingUIManager (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc
index 49d234ee3c8c0894f374a2114997b994d46c93a4..a5072e614f8558f91977d838cb5506b2e161eb7b 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc
@@ -158,9 +158,36 @@ void CheckSafeBrowsingStatus(content::NavigationEntry* entry,
if (!sb_service)
return;
scoped_refptr<SafeBrowsingUIManager> sb_ui_manager = sb_service->ui_manager();
+ safe_browsing::SBThreatType threat_type;
if (sb_ui_manager->IsUrlWhitelistedOrPendingForWebContents(
- entry->GetURL(), false, entry, web_contents, false)) {
- state->fails_malware_check = true;
+ entry->GetURL(), false, entry, web_contents, false, &threat_type)) {
+ switch (threat_type) {
+ case safe_browsing::SB_THREAT_TYPE_SAFE:
+ break;
+ case safe_browsing::SB_THREAT_TYPE_URL_PHISHING:
+ case safe_browsing::SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL:
+ state->malicious_content_status = security_state::SecurityStateModel::
+ MALICIOUS_CONTENT_STATUS_SOCIAL_ENGINEERING;
+ break;
+ case safe_browsing::SB_THREAT_TYPE_URL_MALWARE:
+ case safe_browsing::SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL:
+ state->malicious_content_status = security_state::SecurityStateModel::
+ MALICIOUS_CONTENT_STATUS_MALWARE;
+ break;
+ case safe_browsing::SB_THREAT_TYPE_URL_UNWANTED:
+ state->malicious_content_status = security_state::SecurityStateModel::
+ MALICIOUS_CONTENT_STATUS_UNWANTED_SOFTWARE;
+ break;
+ case safe_browsing::SB_THREAT_TYPE_BINARY_MALWARE_URL:
+ case safe_browsing::SB_THREAT_TYPE_EXTENSION:
+ case safe_browsing::SB_THREAT_TYPE_BLACKLISTED_RESOURCE:
+ case safe_browsing::SB_THREAT_TYPE_API_ABUSE:
+ // These threat types are not currently associated with
+ // interstitials, and thus resources with these threat types are
+ // not ever whitelisted or pending whitelisting.
+ NOTREACHED();
+ break;
+ }
}
}
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager_unittest.cc ('k') | chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698