Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: test/mjsunit/regexp.js

Issue 2481733002: [regexp] Fix a test case for RE.proto[@@search] (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 734
735 // Test that changing a property on RegExp.prototype results in us taking the 735 // Test that changing a property on RegExp.prototype results in us taking the
736 // slow path, which executes RegExp.prototype.exec instead of our 736 // slow path, which executes RegExp.prototype.exec instead of our
737 // RegExpExecStub. 737 // RegExpExecStub.
738 const RegExpPrototypeExec = RegExp.prototype.exec; 738 const RegExpPrototypeExec = RegExp.prototype.exec;
739 RegExp.prototype.exec = function() { throw new Error(); } 739 RegExp.prototype.exec = function() { throw new Error(); }
740 assertThrows(() => "abc".replace(/./, "")); 740 assertThrows(() => "abc".replace(/./, ""));
741 RegExp.prototype.exec = RegExpPrototypeExec; 741 RegExp.prototype.exec = RegExpPrototypeExec;
742 742
743 // Test the code path in RE.proto[@@search] when previousLastIndex is a receiver 743 // Test the code path in RE.proto[@@search] when previousLastIndex is a receiver
744 // but can't be converted to a primitive. This exposed a crash in the 744 // but can't be converted to a primitive. This exposed a crash in an older
745 // C++ implementation of @@search. 745 // C++ implementation of @@search which a) still relied on Object::Equals,
746 // and b) incorrectly returned isolate->pending_exception() on error.
746 747
747 var re = /./; 748 var re = /./;
748 re.lastIndex = { [Symbol.toPrimitive]: 42 }; 749 re.lastIndex = { [Symbol.toPrimitive]: 42 };
749 () => "abc".search(re); 750 try { "abc".search(re); } catch (_) {} // Ensure we don't crash.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698