Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2481733002: [regexp] Fix a test case for RE.proto[@@search] (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix a test case for RE.proto[@@search] The test case did not test anything in its original form. Fix it and add documentation. BUG=v8:5339 Committed: https://crrev.com/f354558c8030c41e99413f7f7ee4c0aa9bcc60ac Cr-Commit-Position: refs/heads/master@{#40794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M test/mjsunit/regexp.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
This fixes an issue found by littledan@ in https://codereview.chromium.org/2452923002/.
4 years, 1 month ago (2016-11-07 08:10:01 UTC) #4
Yang
On 2016/11/07 08:10:01, jgruber wrote: > This fixes an issue found by littledan@ in > ...
4 years, 1 month ago (2016-11-07 09:27:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481733002/1
4 years, 1 month ago (2016-11-07 09:49:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 09:51:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:24:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f354558c8030c41e99413f7f7ee4c0aa9bcc60ac
Cr-Commit-Position: refs/heads/master@{#40794}

Powered by Google App Engine
This is Rietveld 408576698