Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 248173004: Add a tool to list the resources removed when repacking. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
CC:
chromium-reviews, newt (away), Nico
Visibility:
Public.

Description

Add a tool to list the resources removed when repacking. To use: 1) Run gyp with GYP_DEFINES="enable_resource_whitelist_generation=1", build. 2) Pipe the build output into find_used_resources.py to generate a whitelist. 3) Run gy with GYP_DEFINES="enable_resource_whitelist_generation=1 repack_options="--whitelist...", build. 4) Pipe the second build output into list_resources_removed_by_repack.py. Requires grit-i18n r167 to generate the unused resource list in step 3. BUG=338759 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
A tools/resources/list_resources_removed_by_repack.py View 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-23 00:45:43 UTC) #1
Lei Zhang
I meant to roll DEPS for grit-i18n to r167 here, but that's already in progress ...
6 years, 8 months ago (2014-04-23 01:20:09 UTC) #2
Lei Zhang
So WDYT? I've been using this to do a bunch of cleanups.
6 years, 8 months ago (2014-04-25 06:59:40 UTC) #3
aurimas (slooooooooow)
lgtm
6 years, 8 months ago (2014-04-25 16:18:24 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-25 17:16:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/248173004/1
6 years, 8 months ago (2014-04-25 22:14:55 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 23:20:30 UTC) #7
Message was sent while issue was closed.
Change committed as 266280

Powered by Google App Engine
This is Rietveld 408576698