Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: chrome/browser/resources/md_history/history_toolbar.html

Issue 2481693002: [MD History] Make forward/backward work in grouped mode. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
4 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 4 <link rel="import" href="chrome://resources/cr_elements/icons.html">
5 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html"> 5 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html">
6 <link rel="import" href="chrome://resources/cr_elements/cr_toolbar/cr_toolbar.ht ml"> 6 <link rel="import" href="chrome://resources/cr_elements/cr_toolbar/cr_toolbar.ht ml">
7 <link rel="import" href="chrome://history/browser_service.html"> 7 <link rel="import" href="chrome://history/browser_service.html">
8 <link rel="import" href="chrome://history/icons.html"> 8 <link rel="import" href="chrome://history/icons.html">
9 <link rel="import" href="chrome://history/shared_style.html"> 9 <link rel="import" href="chrome://history/shared_style.html">
10 10
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 </div> 224 </div>
225 <template is="dom-if" if="[[isGroupedMode]]"> 225 <template is="dom-if" if="[[isGroupedMode]]">
226 <div id="grouped-buttons-container"> 226 <div id="grouped-buttons-container">
227 <paper-tabs attr-for-selected="value" selected="{{groupedRange}}" 227 <paper-tabs attr-for-selected="value" selected="{{groupedRange}}"
228 id="grouped-range-buttons"> 228 id="grouped-range-buttons">
229 <paper-tab value="0">$i18n{rangeAllTime}</paper-tab> 229 <paper-tab value="0">$i18n{rangeAllTime}</paper-tab>
230 <paper-tab value="1">$i18n{rangeWeek}</paper-tab> 230 <paper-tab value="1">$i18n{rangeWeek}</paper-tab>
231 <paper-tab value="2">$i18n{rangeMonth}</paper-tab> 231 <paper-tab value="2">$i18n{rangeMonth}</paper-tab>
232 </paper-tabs> 232 </paper-tabs>
233 <div id="grouped-nav-container"> 233 <div id="grouped-nav-container">
234 <span id="grouped-date"> 234 <span id="grouped-date" hidden$="[[querying]]">
tsergeant 2016/11/11 02:34:27 IMO, this hiding is unnecessary. It just causes t
calamity 2016/11/22 06:44:56 Done.
235 {{getHistoryInterval_(queryStartTime, queryEndTime)}} 235 {{getHistoryInterval_(queryStartTime, queryEndTime)}}
236 </span> 236 </span>
237 <paper-icon-button icon="history:today" alt="$i18n{rangeToday}" 237 <paper-icon-button id="today-button" icon="history:today"
tsergeant 2016/11/11 02:34:27 Do these buttons actually need IDs?
calamity 2016/11/22 06:44:56 Just for tests?
238 title="$i18n{rangeToday}"></paper-icon-button> 238 alt="$i18n{rangeToday}"
239 <paper-icon-button icon="history:chevron-left" 239 title="$i18n{rangeToday}"
240 alt="$i18n{rangePrevious}" title="$i18n{rangePrevious}" 240 on-tap="todayTapped_"
tsergeant 2016/11/11 02:34:27 Nit: Follow naming style of onTodayTap_ here and b
calamity 2016/11/22 06:44:56 Done.
241 class="rtl-reversible"></paper-icon-button> 241 disabled="[[isToday_(groupedOffset)]]"></paper-icon-button>
242 <paper-icon-button icon="cr:chevron-right" 242 <paper-icon-button id="prev-button" icon="history:chevron-left"
243 alt="$i18n{rangeNext}" title="$i18n{rangeNext}" 243 alt="$i18n{rangePrevious}"
244 class="rtl-reversible"></paper-icon-button> 244 title="$i18n{rangePrevious}"
245 class="rtl-reversible"
246 on-tap="prevTapped_"
247 disabled="[[queryFinished]]"></paper-icon-button>
248 <paper-icon-button id="next-button" icon="cr:chevron-right"
249 alt="$i18n{rangeNext}"
250 title="$i18n{rangeNext}"
251 class="rtl-reversible"
252 on-tap="nextTapped_"
253 disabled="[[isToday_(groupedOffset)]]"></paper-icon-button>
245 </div> 254 </div>
246 </div> 255 </div>
247 </template> 256 </template>
248 </template> 257 </template>
249 <script src="chrome://history/history_toolbar.js"></script> 258 <script src="chrome://history/history_toolbar.js"></script>
250 </dom-module> 259 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698