bluetooth:android: Run error callback when characteristic is destroyed

bluetooth:android: Run error callback when characteristic is destroyed

When a device disconnects we destroy its attributes. This meant that
if a device disconnected during a gatt operation we would drop the
callbacks in BluetoothRemoteGattCharacteristicAndroid. This patches fixes
that by calling the error callback when the characteristic is being
destroyed.

BUG=621901
Committed: https://crrev.com/650a52d4b71f0c029b4278910ed7cf0a127fd3c4
Cr-Commit-Position: refs/heads/master@{#430468}

[ortuno, 2016-11-07 00:35:25]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[ortuno, 2016-11-07 00:35:39]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[commit-bot: I haz the power, 2016-11-07 00:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-11-07 00:35:39]

scheib: PTAL

[commit-bot: I haz the power, 2016-11-07 00:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 00:56:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ortuno, 2016-11-07 01:31:14]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 01:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 03:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 03:01:12]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ortuno, 2016-11-07 03:20:24]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 03:20:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 04:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 04:54:22]

Dry run: This issue passed the CQ dry run.

[scheib, 2016-11-07 22:43:37]

LGTM, but please address:

https://codereview.chromium.org/2481683002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2481683002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:382: #if
defined(OS_ANDROID) || defined(OS_MACOSX)
You modified Windows code as well, but only enabled these tests for Android?
Either this is all done: remove the TODO & enable the tests, or chime in on the
change description and the issue as to what is remaining to be done.

[ortuno, 2016-11-08 00:05:12]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-11-08 00:05:13]

Thanks!

https://codereview.chromium.org/2481683002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2481683002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:382: #if
defined(OS_ANDROID) || defined(OS_MACOSX)
On 2016/11/07 at 22:43:37, scheib wrote:
> You modified Windows code as well, but only enabled these tests for Android?
Either this is all done: remove the TODO & enable the tests, or chime in on the
change description and the issue as to what is remaining to be done.

GATT Connection is not implemented on windows yet. Fixed TODO link and
description.

[ortuno, 2016-11-08 00:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2481683002/#ps60001
(title: "Fix TODO")

[commit-bot: I haz the power, 2016-11-08 00:05:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:37:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-08 01:43:23]

Description was changed from

==========
bluetooth:android: Run error callback when characteristic is destroyed

When a device disconnects we destroy its attributes. This meant that
if a device disconnected during a gatt operation we would drop the
callbacks in BluetoothRemoteGattCharacteristicAndroid. This patches fixes
that by calling the error callback when the characteristic is being
destroyed.

BUG=621901
==========

to

==========
bluetooth:android: Run error callback when characteristic is destroyed

When a device disconnects we destroy its attributes. This meant that
if a device disconnected during a gatt operation we would drop the
callbacks in BluetoothRemoteGattCharacteristicAndroid. This patches fixes
that by calling the error callback when the characteristic is being
destroyed.

BUG=621901

Committed: https://crrev.com/650a52d4b71f0c029b4278910ed7cf0a127fd3c4
Cr-Commit-Position: refs/heads/master@{#430468}
==========

[commit-bot: I haz the power, 2016-11-08 01:43:23]

Patchset 4 (id:??) landed as
https://crrev.com/650a52d4b71f0c029b4278910ed7cf0a127fd3c4
Cr-Commit-Position: refs/heads/master@{#430468}