media: Make sure we transition back to a non-loading state

media/blink/multibuffer_reader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 160 matching lines @@
 }
 
 void MultiBufferReader::NotifyAvailableRange(
     const Interval<MultiBufferBlockId>& range) {
   // Update end_ if we can.
   if (range.end > range.begin) {
     UpdateEnd(range.end);
   }
   UpdateInternalState();
   if (!progress_callback_.is_null()) {
-    // We redirect the call through a weak pointer to ourselves to guarantee
-    // there are no callbacks from us after we've been destroyed.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
-        base::Bind(
-            &MultiBufferReader::Call, weak_factory_.GetWeakPtr(),
-            base::Bind(progress_callback_,
-                       static_cast<int64_t>(range.begin)
-                           << multibuffer_->block_size_shift(),
-                       (static_cast<int64_t>(range.end)
-                        << multibuffer_->block_size_shift()) +
-                           multibuffer_->UncommittedBytesAt(range.end))));
+        base::Bind(progress_callback_, static_cast<int64_t>(range.begin)
+                                           << multibuffer_->block_size_shift(),
+                   (static_cast<int64_t>(range.end)
+                    << multibuffer_->block_size_shift()) +
+                       multibuffer_->UncommittedBytesAt(range.end)));
   }
 }
 
 void MultiBufferReader::UpdateInternalState() {
   int64_t effective_preload = loading_ ? preload_high_ : preload_low_;
 
   loading_ = false;
   if (preload_pos_ == -1) {
     preload_pos_ = block(pos_);
     DCHECK_GE(preload_pos_, 0);
@@ skipping 39 matching lines @@
   // Use a rangemap to compute the diff in pinning.
   IntervalMap<MultiBuffer::BlockId, int32_t> tmp;
   tmp.IncrementInterval(pinned_range_.begin, pinned_range_.end, -1);
   tmp.IncrementInterval(begin, end, 1);
   multibuffer_->PinRanges(tmp);
   pinned_range_.begin = begin;
   pinned_range_.end = end;
 }
 
 }  // namespace media