Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 2481653002: Move FeaturePolicy object to SecurityContext (Closed)

Created:
4 years, 1 month ago by iclelland
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FeaturePolicy object to SecurityContext BUG=661273 Committed: https://crrev.com/b15288aa90bef13486a61506969b4581b302e269 Cr-Commit-Position: refs/heads/master@{#430700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.h View 4 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
iclelland
+r mkwst -- can you PTAL? It was suggested by a couple of people that ...
4 years, 1 month ago (2016-11-07 21:38:53 UTC) #2
Mike West
LGTM. Moving this to `SecurityContext` will make it easier to apply restrictions to `Worker` environments ...
4 years, 1 month ago (2016-11-08 14:19:37 UTC) #7
Mike West
Also, please link this to a bug. Maybe 661273?
4 years, 1 month ago (2016-11-08 14:19:49 UTC) #8
iclelland
On 2016/11/08 14:19:49, Mike West wrote: > Also, please link this to a bug. Maybe ...
4 years, 1 month ago (2016-11-08 20:11:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481653002/1
4 years, 1 month ago (2016-11-08 20:20:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 20:25:36 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 20:41:36 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b15288aa90bef13486a61506969b4581b302e269
Cr-Commit-Position: refs/heads/master@{#430700}

Powered by Google App Engine
This is Rietveld 408576698