Issue 2481643002: Support for Quick Fixes with the new analysis driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2481643002: Support for Quick Fixes with the new analysis driver. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support for Quick Fixes with the new analysis driver. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fa6cfb35158224dc7b80c0bc0ac20b830513762b

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -26 lines)			Patch
	M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View		5 chunks	+71 lines, -26 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm Are we testing all of the services under both the current and future (analysis ...

4 years, 1 month ago (2016-11-06 17:44:40 UTC) #3

scheglov

Committed patchset #1 (id:1) manually as fa6cfb35158224dc7b80c0bc0ac20b830513762b (presubmit successful).

4 years, 1 month ago (2016-11-06 18:09:40 UTC) #5

scheglov

4 years, 1 month ago (2016-11-06 18:20:42 UTC) #6

Message was sent while issue was closed.

On 2016/11/06 17:44:40, Brian Wilkerson wrote:
> lgtm
> 
> Are we testing all of the services under both the current and future (analysis
> driver) implementations?

No, not yet.
Testing is much wider task.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages