Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2481553002: Move outline out of StyleBackgroundData into StyleRareNonInheritedData (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move outline out of StyleBackgroundData into StyleRareNonInheritedData Outline has nothing to do with background. Move it into StylerareNonInheritedData. This makes clear that StyleBackgroundData::operator==() means backgrounds are the same. Committed: https://crrev.com/2357347482ca9ef9cb62ed107ed206a1bca6c6db Cr-Commit-Position: refs/heads/master@{#430128}

Patch Set 1 #

Patch Set 2 : Remove StyleBackgroundData::visuallyEqual() #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -49 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 chunks +19 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBackgroundData.h View 1 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleBackgroundData.cpp View 1 1 chunk +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 2 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Xianzhu
This is a preparation of the CL to improve paint invalidation on background change (mainly ...
4 years, 1 month ago (2016-11-04 21:46:38 UTC) #2
pdr.
On 2016/11/04 at 21:46:38, wangxianzhu wrote: > This is a preparation of the CL to ...
4 years, 1 month ago (2016-11-04 22:47:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481553002/40001
4 years, 1 month ago (2016-11-05 01:12:03 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-05 02:35:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 02:37:16 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2357347482ca9ef9cb62ed107ed206a1bca6c6db
Cr-Commit-Position: refs/heads/master@{#430128}

Powered by Google App Engine
This is Rietveld 408576698