Android: Default symbol_level=1 for GN configs where 2 breaks things

Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
Committed: https://crrev.com/c4ffc5d95c07e6777d4c57dc086d1b681a830a34
Cr-Commit-Position: refs/heads/master@{#430618}

[agrieve, 2016-11-04 20:08:50]

Description was changed from

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
==========

to

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
==========

[agrieve, 2016-11-04 20:08:50]

agrieve@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2016-11-07 12:56:43]

If the default triggering an assert is too annoying then this seems fine; I only
didn't change the default so that people wouldn't silently have gdb broken.

https://codereview.chromium.org/2481523002/diff/20001/build/config/compiler/c...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2481523002/diff/20001/build/config/compiler/c...
build/config/compiler/compiler.gni:81: !(android_64bit_target_cpu &&
!build_apk_secondary_abi)) {
Can you add the build_apk_secondary_abi condition to the assert as well to
match?

[agrieve, 2016-11-07 19:44:00]

Yeah, there's certainly a reason for either side of doing this. I think enough
people have struggled with this (even after the assert was added), that it's a
good idea to change the default. I guess we'll see if people now start asking
why gdb is broken :P

https://codereview.chromium.org/2481523002/diff/20001/build/config/compiler/c...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2481523002/diff/20001/build/config/compiler/c...
build/config/compiler/compiler.gni:81: !(android_64bit_target_cpu &&
!build_apk_secondary_abi)) {
On 2016/11/07 12:56:43, Torne wrote:
> Can you add the build_apk_secondary_abi condition to the assert as well to
> match?

Done.

[agrieve, 2016-11-07 19:44:06]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:44:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:12:43]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-11-08 14:45:22]

lgtm

[agrieve, 2016-11-08 15:28:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:34:21]

Description was changed from

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
==========

to

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
==========

[commit-bot: I haz the power, 2016-11-08 15:34:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 15:38:23]

Description was changed from

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948
==========

to

==========
Android: Default symbol_level=1 for GN configs where 2 breaks things

BUG=648948

Committed: https://crrev.com/c4ffc5d95c07e6777d4c57dc086d1b681a830a34
Cr-Commit-Position: refs/heads/master@{#430618}
==========

[commit-bot: I haz the power, 2016-11-08 15:38:24]

Patchset 3 (id:??) landed as
https://crrev.com/c4ffc5d95c07e6777d4c57dc086d1b681a830a34
Cr-Commit-Position: refs/heads/master@{#430618}