Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2481503002: Fix JavaScriptBlockingTestWebState constructor to initialize |observer_| (Closed)

Created:
4 years, 1 month ago by kkhorimoto
Modified:
4 years, 1 month ago
Reviewers:
baxley
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix JavaScriptBlockingTestWebState constructor to initialize |observer_| BUG=none Committed: https://crrev.com/4ae578761b1eca3e23ecc813d09d28c6054660ca Cr-Commit-Position: refs/heads/master@{#429965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/ui/dialogs/javascript_dialog_blocking_util_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kkhorimoto
Go ahead and CQ if it looks good to you
4 years, 1 month ago (2016-11-04 18:48:34 UTC) #2
baxley
lgtm
4 years, 1 month ago (2016-11-04 18:50:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481503002/1
4 years, 1 month ago (2016-11-04 18:50:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 19:06:40 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 19:18:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ae578761b1eca3e23ecc813d09d28c6054660ca
Cr-Commit-Position: refs/heads/master@{#429965}

Powered by Google App Engine
This is Rietveld 408576698