Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 2481483002: Mojo C++ bindings: make chrome/browser/ui/webui mojom target use STL types. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/engagement/BUILD.gn ('k') | chrome/browser/ui/webui/omnibox/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc
diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
index 26cab92c5b39c4e76d16d373207c7382a2bb95c5..b66a45888927aa56d6bd7e862fedc63e987cd878 100644
--- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
+++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
@@ -6,6 +6,7 @@
#include <cmath>
#include <utility>
+#include <vector>
#include "base/macros.h"
#include "chrome/browser/engagement/site_engagement_service.h"
@@ -37,11 +38,12 @@ class SiteEngagementUIHandlerImpl : public mojom::SiteEngagementUIHandler {
// mojom::SiteEngagementUIHandler overrides:
void GetSiteEngagementInfo(
const GetSiteEngagementInfoCallback& callback) override {
- mojo::Array<mojom::SiteEngagementInfoPtr> engagement_info;
-
SiteEngagementService* service = SiteEngagementService::Get(profile_);
+ std::map<GURL, double> score_map = service->GetScoreMap();
- for (const std::pair<GURL, double>& info : service->GetScoreMap()) {
+ std::vector<mojom::SiteEngagementInfoPtr> engagement_info;
+ engagement_info.reserve(score_map.size());
+ for (const auto& info : score_map) {
mojom::SiteEngagementInfoPtr origin_info(
mojom::SiteEngagementInfo::New());
origin_info->origin = info.first;
« no previous file with comments | « chrome/browser/ui/webui/engagement/BUILD.gn ('k') | chrome/browser/ui/webui/omnibox/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698