Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2481463002: use reversePathTo in place of addPathReverse (Closed)

Created:
4 years, 1 month ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use reversePathTo in place of addPathReverse Path ops was using addPathReverse, instead of reversePathTo. The former adds a moveTo always, and the latter requires that the caller add the moveTo if needed. Simplify the reversePathTo implementation. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2481463002 Committed: https://skia.googlesource.com/skia/+/d8db392be9dd1887df04b10b5670991d6b098c17 Committed: https://skia.googlesource.com/skia/+/51c5678f258736736c4a5d48d4e82c73be225428

Patch Set 1 #

Patch Set 2 : fix nanobench; stop after one contour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M include/core/SkPath.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/pathops/SkPathOps.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 1 chunk +20 lines, -28 lines 0 comments Download
M src/pathops/SkOpBuilder.cpp View 3 chunks +13 lines, -7 lines 0 comments Download
M src/pathops/SkPathWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
caryclark
4 years, 1 month ago (2016-11-04 18:18:54 UTC) #4
reed1
lgtm
4 years, 1 month ago (2016-11-04 18:25:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481463002/1
4 years, 1 month ago (2016-11-04 18:37:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d8db392be9dd1887df04b10b5670991d6b098c17
4 years, 1 month ago (2016-11-04 18:38:43 UTC) #11
caryclark
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2478763003/ by caryclark@google.com. ...
4 years, 1 month ago (2016-11-04 20:31:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481463002/20001
4 years, 1 month ago (2016-11-07 13:08:34 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 13:09:30 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/51c5678f258736736c4a5d48d4e82c73be225428

Powered by Google App Engine
This is Rietveld 408576698