Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3347)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 2481453002: Add "PasswordManager.SignInPromoDismissalCount" histogram. (Closed)
Patch Set: comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
index a037e399ae11568c5cd189856e8009eb3db31589..370731a7ea41f70104b7f9083caf7d1dda339ec0 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
@@ -48,6 +48,10 @@ using ::testing::_;
namespace {
const char kFakeGroup[] = "FakeGroup";
+const char kSignInPromoCountTilClickMetric[] =
+ "PasswordManager.SignInPromoCountTilClick";
+const char kSignInPromoDismissalCountMetric[] =
+ "PasswordManager.SignInPromoDismissalCount";
const char kSignInPromoDismissalReasonMetric[] = "PasswordManager.SignInPromo";
const char kSiteOrigin[] = "http://example.com/login";
const char kUsername[] = "Admin";
@@ -371,6 +375,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SuppressSignInPromo) {
EXPECT_FALSE(model()->ReplaceToShowSignInPromoIfNeeded());
DestroyModel();
histogram_tester.ExpectTotalCount(kSignInPromoDismissalReasonMetric, 0);
+ histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
+ histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
}
TEST_F(ManagePasswordsBubbleModelTest, SignInPromoOK) {
@@ -395,6 +401,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoOK) {
histogram_tester.ExpectUniqueSample(
kSignInPromoDismissalReasonMetric,
password_manager::metrics_util::CHROME_SIGNIN_OK, 1);
+ histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
+ histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
EXPECT_TRUE(prefs()->GetBoolean(
password_manager::prefs::kWasSignInPasswordPromoClicked));
}
@@ -420,6 +428,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoCancel) {
histogram_tester.ExpectUniqueSample(
kSignInPromoDismissalReasonMetric,
password_manager::metrics_util::CHROME_SIGNIN_CANCEL, 1);
+ histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
+ histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
EXPECT_TRUE(prefs()->GetBoolean(
password_manager::prefs::kWasSignInPasswordPromoClicked));
}
@@ -444,6 +454,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoDismiss) {
histogram_tester.ExpectUniqueSample(
kSignInPromoDismissalReasonMetric,
password_manager::metrics_util::CHROME_SIGNIN_DISMISSED, 1);
+ histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
+ histogram_tester.ExpectUniqueSample(kSignInPromoDismissalCountMetric, 1, 1);
EXPECT_FALSE(prefs()->GetBoolean(
password_manager::prefs::kWasSignInPasswordPromoClicked));
}
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698