Add "PasswordManager.SignInPromoDismissalCount" histogram.

chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 85 matching lines @@
 
   void set_sign_in_promo_dismissal_reason(
       password_manager::metrics_util::SyncSignInUserAction reason) {
     sign_in_promo_dismissal_reason_ = reason;
   }
 
   void SetClockForTesting(std::unique_ptr<base::Clock> clock) {
     clock_ = std::move(clock);
   }
 
+  void set_sign_in_promo_count(int count) {
+    sign_in_promo_count = count;
+  }
+
  private:
   // The way the bubble appeared.
   const password_manager::metrics_util::UIDisplayDisposition
   display_disposition_;
 
   // Dismissal reason for a bubble.
   password_manager::metrics_util::UIDismissalReason dismissal_reason_;
 
   // Dismissal reason for the update bubble.
   password_manager::metrics_util::UpdatePasswordSubmissionEvent
       update_password_submission_event_;
 
   // Dismissal reason for the Chrome Sign in bubble.
   password_manager::metrics_util::SyncSignInUserAction
       sign_in_promo_dismissal_reason_;
 
   // Current statistics for the save password bubble;
   password_manager::InteractionsStats interaction_stats_;
 
   // Used to retrieve the current time, in base::Time units.
   std::unique_ptr<base::Clock> clock_;
 
+  // Number of times the sign-in promo was shown to the user.
+  int sign_in_promo_count;

[Ilya Sherman, 2016/11/05 01:31:39]

nit: I'd add "shown" before "count"

[vasilii, 2016/11/07 10:40:24]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(InteractionKeeper);
 };
 
 ManagePasswordsBubbleModel::InteractionKeeper::InteractionKeeper(
     password_manager::InteractionsStats stats,
     password_manager::metrics_util::UIDisplayDisposition display_disposition)
     : display_disposition_(display_disposition),
       dismissal_reason_(metrics_util::NO_DIRECT_INTERACTION),
       update_password_submission_event_(metrics_util::NO_UPDATE_SUBMISSION),
       sign_in_promo_dismissal_reason_(metrics_util::CHROME_SIGNIN_DISMISSED),
       interaction_stats_(std::move(stats)),
-      clock_(new base::DefaultClock) {}
+      clock_(new base::DefaultClock),
+      sign_in_promo_count(0) {}
 
 void ManagePasswordsBubbleModel::InteractionKeeper::ReportInteractions(
     const ManagePasswordsBubbleModel* model) {
   if (model->state() == password_manager::ui::PENDING_PASSWORD_STATE) {
     Profile* profile = model->GetProfile();
     if (profile) {
       if (GetSmartLockBrandingState(profile) ==
           password_bubble_experiment::SmartLockBranding::FULL) {
         password_bubble_experiment::RecordSavePromptFirstRunExperienceWasShown(
             profile->GetPrefs());
@@ skipping 13 matching lines @@
       }
     }
   }
 
   if (model->state() == password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) {
     metrics_util::LogAutoSigninPromoUserAction(sign_in_promo_dismissal_reason_);
     if (sign_in_promo_dismissal_reason_ ==
             password_manager::metrics_util::CHROME_SIGNIN_OK ||
         sign_in_promo_dismissal_reason_ ==
             password_manager::metrics_util::CHROME_SIGNIN_CANCEL) {
-      DCHECK(model->delegate_);
-      int show_count = model->GetProfile()->GetPrefs()->GetInteger(
-          password_manager::prefs::kNumberSignInPasswordPromoShown);
       UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilClick",
-                               show_count);
+                               sign_in_promo_count);
+    } else {
+      UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoDismissalCount",

[Ilya Sherman, 2016/11/05 01:31:40]

Does CHROME_SIGNIN_CANCEL not correspond to a dismissal?

[vasilii, 2016/11/07 10:40:24]

No. The request was to count implicit dismissals. CHROME_SIGNIN_CANCEL and
CHROME_SIGNIN_OK both contribute to click-through rate. The dialog won't show up
again.

+                               sign_in_promo_count);
     }
   } else if (model->state() !=
              password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
     // We have separate metrics for the Update bubble so do not record dismissal
     // reason for it.
     metrics_util::LogUIDismissalReason(dismissal_reason_);
   }
 
   if (model->state() == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE ||
       model->state() == password_manager::ui::PENDING_PASSWORD_STATE) {
@@ skipping 251 matching lines @@
   const browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(GetProfile());
   if (password_bubble_experiment::ShouldShowChromeSignInPasswordPromo(
           prefs, sync_service)) {
     interaction_keeper_->ReportInteractions(this);
     title_brand_link_range_ = gfx::Range();
     title_ = l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SIGNIN_PROMO_TITLE);
     state_ = password_manager::ui::CHROME_SIGN_IN_PROMO_STATE;
     int show_count = prefs->GetInteger(
         password_manager::prefs::kNumberSignInPasswordPromoShown);
+    show_count++;

[Ilya Sherman, 2016/11/05 01:31:39]

nit: Please use pre-increment.

[vasilii, 2016/11/07 10:40:24]

Why?

[Ilya Sherman, 2016/11/07 19:43:20]

Hmm, I think the style guide used to recommend pre-incrmenet universally.  I
guess that's not the case anymore, so nevermind.

[vabr (Chromium), 2016/11/08 08:36:33]

The style guide still requires it for iterators, but explicitly says it does not
matter for non-object values:
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement

     prefs->SetInteger(password_manager::prefs::kNumberSignInPasswordPromoShown,
-                      show_count + 1);
+                      show_count);
+    interaction_keeper_->set_sign_in_promo_count(show_count);

[Ilya Sherman, 2016/11/05 01:31:39]

What's the purpose of tracking this in two locations?  That is, why not just
track it exclusively via the pref that's being set above?

[vasilii, 2016/11/07 10:40:24]

Because if one closes the tab then GetWebContents() returns 0.
PasswordsModelDelegate may also be null. Their destruction order can't be
predicted. I can't find a profile then.

     return true;
   }
   return false;
 }
 
 void ManagePasswordsBubbleModel::SetClockForTesting(
     std::unique_ptr<base::Clock> clock) {
   interaction_keeper_->SetClockForTesting(std::move(clock));
 }
 
@@ skipping 40 matching lines @@
     return metrics_util::NO_UPDATE_SUBMISSION;
   }
   if (state_ != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE)
     return metrics_util::NO_UPDATE_SUBMISSION;
   if (password_overridden_)
     return update_events[3][behavior];
   if (ShouldShowMultipleAccountUpdateUI())
     return update_events[2][behavior];
   return update_events[1][behavior];
 }