Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/offline_pages/content/background_loader/BUILD.gn

Issue 2481443002: Implementation (cc file) for background loader contents. (Closed)
Patch Set: Format and build Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/content/background_loader/BUILD.gn
diff --git a/extensions/browser/api/app_current_window_internal/BUILD.gn b/components/offline_pages/content/background_loader/BUILD.gn
similarity index 54%
copy from extensions/browser/api/app_current_window_internal/BUILD.gn
copy to components/offline_pages/content/background_loader/BUILD.gn
index 980c2d090d5c636ac2425d226f3dd9b6d6870e99..dff3ed9955c750cb784fb677dc9feb20a7e13aed 100644
--- a/extensions/browser/api/app_current_window_internal/BUILD.gn
+++ b/components/offline_pages/content/background_loader/BUILD.gn
@@ -2,14 +2,18 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("app_current_window_internal") {
+if (is_android) {
+ import("//build/config/android/rules.gni")
+}
+
+static_library("background_loader") {
dewittj 2016/11/08 00:16:39 do we want this to be a library or a source_set?
chili 2016/11/10 22:05:07 I don't know, but the style guide seems to say tha
dewittj 2016/11/14 16:36:36 The app_current_... is due to Git similarity match
sources = [
- "app_current_window_internal_api.cc",
- "app_current_window_internal_api.h",
+ "background_loader_contents.cc",
+ "background_loader_contents.h",
]
deps = [
"//content/public/browser",
- "//extensions/common/api",
+ "//url",
]
}

Powered by Google App Engine
This is Rietveld 408576698