[Interpreter] Add IsInterpreted() to JSFunction and use to fix test-heap tests.

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 7360 matching lines @@
   // [name]: Function name.
   DECL_ACCESSORS(name, Object)
 
   // [code]: Function code.
   DECL_ACCESSORS(code, Code)
 
   // Get the abstract code associated with the function, which will either be
   // a Code object or a BytecodeArray.
   inline AbstractCode* abstract_code();
 
+  inline bool IsInterpreted() const;

[Michael Starzinger, 2016/11/09 12:07:23]

nit: Please add a similar comment (like in JSFunction) here. Maybe it might make
sense to briefly mention that the result of this predicate can diverge from the
one in JSFunction and self-healing in the interpreter entry-stub will "heal"
such diverging results (not sure how to best phrase this).

The point I am trying to bring across with the comment is that there is a good
reason for the predicate to exist on both, {JSFunction} as well as
{SharedFunctionInfo}, because "function->shared()->IsInterpreted()" means
something else than "function->IsInterpreted()".

[rmcilroy, 2016/11/09 16:50:10]

Good point, added a comment as-such to both functions

+
   inline void ReplaceCode(Code* code);
   inline bool HasBaselineCode() const;
 
   // [optimized_code_map]: Map from native context to optimized code
   // and a shared literals array.
   DECL_ACCESSORS(optimized_code_map, FixedArray)
 
   // Returns entry from optimized code map for specified context and OSR entry.
   // Note that {code == nullptr, literals == nullptr} indicates no matching
   // entry has been found, whereas {code, literals == nullptr} indicates that
@@ skipping 926 matching lines @@
   inline void set_code_no_write_barrier(Code* code);
   inline void ReplaceCode(Code* code);
 
   // Get the abstract code associated with the function, which will either be
   // a Code object or a BytecodeArray.
   inline AbstractCode* abstract_code();
 
   // Tells whether this function inlines the given shared function info.
   bool Inlines(SharedFunctionInfo* candidate);
 
+  // Tells whether or not this function is interpreted.
+  inline bool IsInterpreted();
+
   // Tells whether or not this function has been optimized.
   inline bool IsOptimized();
 
   // Mark this function for lazy recompilation. The function will be recompiled
   // the next time it is executed.
   void MarkForBaseline();
   void MarkForOptimization();
   void AttemptConcurrentOptimization();
 
   // Tells whether or not the function is already marked for lazy recompilation.
@@ skipping 3432 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_