[Interpreter] Add IsInterpreted() to JSFunction and use to fix test-heap tests.

[Interpreter] Add IsInterpreted() to JSFunction and use to fix test-heap tests.

Adds an IsInterpreted() function to both SharedFunctionInfo and JSFunction.
This is used to fix the test-heap code-aging tests since Ignition doesn't
age code.

BUG=v8:4680
Committed: https://crrev.com/abad9b2ff9dbce29659b83ba9a9fc9d2ee004b8b
Cr-Commit-Position: refs/heads/master@{#40868}

[rmcilroy, 2016-11-04 14:22:37]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 14:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 14:40:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[rmcilroy, 2016-11-04 20:18:19]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:37:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[rmcilroy, 2016-11-04 21:11:44]

Patchset #2 (id:20001) has been deleted

[rmcilroy, 2016-11-04 21:12:01]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 21:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:45:51]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-07 08:51:14]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-11-07 08:51:14]

Michi PTAL, thanks.

[rmcilroy, 2016-11-09 11:52:21]

Ping, could you take a look please Michi?

[rmcilroy, 2016-11-09 11:52:47]

rmcilroy@chromium.org changed reviewers:
+ ishell@chromium.org

[rmcilroy, 2016-11-09 11:52:48]

ishell@chromium.org: Please review changes in ic

[Michael Starzinger, 2016-11-09 12:07:23]

LGTM modulo better documentation (see comment below).

https://codereview.chromium.org/2481433002/diff/40001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2481433002/diff/40001/src/objects.h#newcode7381
src/objects.h:7381: inline bool IsInterpreted() const;
nit: Please add a similar comment (like in JSFunction) here. Maybe it might make
sense to briefly mention that the result of this predicate can diverge from the
one in JSFunction and self-healing in the interpreter entry-stub will "heal"
such diverging results (not sure how to best phrase this).

The point I am trying to bring across with the comment is that there is a good
reason for the predicate to exist on both, {JSFunction} as well as
{SharedFunctionInfo}, because "function->shared()->IsInterpreted()" means
something else than "function->IsInterpreted()".

[Igor Sheludko, 2016-11-09 12:17:21]

lgtm

https://codereview.chromium.org/2481433002/diff/40001/test/cctest/heap/test-h...
File test/cctest/heap/test-heap.cc (right):

https://codereview.chromium.org/2481433002/diff/40001/test/cctest/heap/test-h...
test/cctest/heap/test-heap.cc:1618: i::FLAG_allow_natives_syntax = true;
Spurious change?

[rmcilroy, 2016-11-09 16:50:10]

Comments addressed, landing.

https://codereview.chromium.org/2481433002/diff/40001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2481433002/diff/40001/src/objects.h#newcode7381
src/objects.h:7381: inline bool IsInterpreted() const;
On 2016/11/09 12:07:23, Michael Starzinger wrote:
> nit: Please add a similar comment (like in JSFunction) here. Maybe it might
make
> sense to briefly mention that the result of this predicate can diverge from
the
> one in JSFunction and self-healing in the interpreter entry-stub will "heal"
> such diverging results (not sure how to best phrase this).
> 
> The point I am trying to bring across with the comment is that there is a good
> reason for the predicate to exist on both, {JSFunction} as well as
> {SharedFunctionInfo}, because "function->shared()->IsInterpreted()" means
> something else than "function->IsInterpreted()".

Good point, added a comment as-such to both functions

https://codereview.chromium.org/2481433002/diff/40001/test/cctest/heap/test-h...
File test/cctest/heap/test-heap.cc (right):

https://codereview.chromium.org/2481433002/diff/40001/test/cctest/heap/test-h...
test/cctest/heap/test-heap.cc:1618: i::FLAG_allow_natives_syntax = true;
On 2016/11/09 12:17:21, Igor Sheludko wrote:
> Spurious change?

Yup, was trying to fix this test too and failed - thanks, fixed!

[rmcilroy, 2016-11-09 16:50:15]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-11-09 16:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2481433002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-09 16:50:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 17:19:40]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:27:53]

Description was changed from

==========
[Interpreter] Add IsInterpreted() to JSFunction and use to fix test-heap tests.

Adds an IsInterpreted() function to both SharedFunctionInfo and JSFunction.
This is used to fix the test-heap code-aging tests since Ignition doesn't
age code.

BUG=v8:4680
==========

to

==========
[Interpreter] Add IsInterpreted() to JSFunction and use to fix test-heap tests.

Adds an IsInterpreted() function to both SharedFunctionInfo and JSFunction.
This is used to fix the test-heap code-aging tests since Ignition doesn't
age code.

BUG=v8:4680

Committed: https://crrev.com/abad9b2ff9dbce29659b83ba9a9fc9d2ee004b8b
Cr-Commit-Position: refs/heads/master@{#40868}
==========

[commit-bot: I haz the power, 2016-11-17 22:27:54]

Patchset 4 (id:??) landed as
https://crrev.com/abad9b2ff9dbce29659b83ba9a9fc9d2ee004b8b
Cr-Commit-Position: refs/heads/master@{#40868}