[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not set

[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not set

Currently the Media Router dialog shows up off-center for a split second, then gets center-aligned as its contents load and size gets set dynamically. This change makes GetDialogSize() set the dialog width if it's not set yet, so that the dialog appears in the center from the beginning.

BUG=664705
Committed: https://crrev.com/9d8038f14a717e711c1ab57997559b8a564d76bd
Cr-Commit-Position: refs/heads/master@{#431756}

[takumif, 2016-11-10 23:06:47]

Description was changed from

==========
.

BUG=
==========

to

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=
==========

[takumif, 2016-11-10 23:06:47]

takumif@chromium.org changed reviewers:
+ imcheng@chromium.org

[takumif, 2016-11-10 23:08:12]

Please take a look, thanks!

[takumif, 2016-11-10 23:34:43]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org
- imcheng@chromium.org

[takumif, 2016-11-10 23:34:43]

Please take a look, thanks!

[apacible, 2016-11-11 00:30:21]

Has this been tested on different platforms? Previously when we tried this, a
placeholder (min height?) appeared before the full WebUI, more notably seen on
osx. That probably still looks better than the sideways dialog traversal though.

[takumif, 2016-11-11 18:47:05]

On 2016/11/11 00:30:21, apacible wrote:
> Has this been tested on different platforms? Previously when we tried this, a
> placeholder (min height?) appeared before the full WebUI, more notably seen on
> osx. That probably still looks better than the sideways dialog traversal
though.

Tried on Linux/Windows/macOS. It doesn't seem to cause any negative changes.
This change doesn't change the height (which is 1px before the first dynamic
resizing on macOS), so it shouldn't (and doesn't, in my testing) change how the
dialog moves vertically.

[apacible, 2016-11-11 22:58:22]

On 2016/11/11 18:47:05, takumif wrote:
> On 2016/11/11 00:30:21, apacible wrote:
> > Has this been tested on different platforms? Previously when we tried this,
a
> > placeholder (min height?) appeared before the full WebUI, more notably seen
on
> > osx. That probably still looks better than the sideways dialog traversal
> though.
> 
> Tried on Linux/Windows/macOS. It doesn't seem to cause any negative changes.
> This change doesn't change the height (which is 1px before the first dynamic
> resizing on macOS), so it shouldn't (and doesn't, in my testing) change how
the
> dialog moves vertically.

Cool! Sounds like some dialog impl changed since it works now. lgtm yay!

Please attach a crbug.

[takumif, 2016-11-12 02:06:43]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 02:07:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[takumif, 2016-11-12 02:35:43]

Description was changed from

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=
==========

to

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=664705
==========

[commit-bot: I haz the power, 2016-11-12 03:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 03:15:47]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-11-12 03:20:14]

On 2016/11/11 22:58:22, apacible wrote:
> On 2016/11/11 18:47:05, takumif wrote:
> > On 2016/11/11 00:30:21, apacible wrote:
> > > Has this been tested on different platforms? Previously when we tried
this,
> a
> > > placeholder (min height?) appeared before the full WebUI, more notably
seen
> on
> > > osx. That probably still looks better than the sideways dialog traversal
> > though.
> > 
> > Tried on Linux/Windows/macOS. It doesn't seem to cause any negative changes.
> > This change doesn't change the height (which is 1px before the first dynamic
> > resizing on macOS), so it shouldn't (and doesn't, in my testing) change how
> the
> > dialog moves vertically.
> 
> Cool! Sounds like some dialog impl changed since it works now. lgtm yay!
> 
> Please attach a crbug.

Thanks! crbug attached.

[takumif, 2016-11-12 03:20:18]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-11-12 03:20:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 03:38:50]

Description was changed from

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=664705
==========

to

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=664705
==========

[commit-bot: I haz the power, 2016-11-12 03:38:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-12 03:40:51]

Description was changed from

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=664705
==========

to

==========
[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not
set

Currently the Media Router dialog shows up off-center for a split second, then
gets center-aligned as its contents load and size gets set dynamically. This
change makes GetDialogSize() set the dialog width if it's not set yet, so that
the dialog appears in the center from the beginning.

BUG=664705

Committed: https://crrev.com/9d8038f14a717e711c1ab57997559b8a564d76bd
Cr-Commit-Position: refs/heads/master@{#431756}
==========

[commit-bot: I haz the power, 2016-11-12 03:40:53]

Patchset 1 (id:??) landed as
https://crrev.com/9d8038f14a717e711c1ab57997559b8a564d76bd
Cr-Commit-Position: refs/heads/master@{#431756}