|
|
Chromium Code Reviews
DescriptionChecks the DomKey in the non-printable map to determine whether a key event is non-character.
And fallback to check the character value.
BUG=633238
Committed: https://crrev.com/958f9a87ed3bf08d72839ce1e078f967ff4dabd6
Cr-Commit-Position: refs/heads/master@{#434412}
Patch Set 1 #Patch Set 2 : Checks the DomKey in the non-printable map to determine whether a key event is non-character. #
Messages
Total messages: 28 (16 generated)
The CQ bit was checked by shuchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
shuchen@chromium.org changed reviewers: + kpschoedel@chromium.org, spang@chromium.org
Can you please review this cl? Thanks.
LGTM. Sorry for the delay; it took me a while to get a good build again to verify the fix.
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by shuchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kpschoedel@chromium.org Link to the patchset: https://codereview.chromium.org/2481413006/#ps20001 (title: "Checks the DomKey in the non-printable map to determine whether a key event is non-character.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480032321788560,
"parent_rev": "83376e0f401508b795214a3c2ef1b0a7468b98a7", "commit_rev":
"22a1a8e58991d0b7981f0014c25e26e6251d237e"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Checks the DomKey in the non-printable map to determine whether a key event is non-character. And fallback to check the character value. BUG=633238 ========== to ========== Checks the DomKey in the non-printable map to determine whether a key event is non-character. And fallback to check the character value. BUG=633238 Committed: https://crrev.com/958f9a87ed3bf08d72839ce1e078f967ff4dabd6 Cr-Commit-Position: refs/heads/master@{#434412} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/958f9a87ed3bf08d72839ce1e078f967ff4dabd6 Cr-Commit-Position: refs/heads/master@{#434412} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
