Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2481413006: Checks the DomKey in the non-printable map to determine whether a key event is non-character. (Closed)

Created:
4 years, 1 month ago by Shu Chen
Modified:
4 years ago
Reviewers:
kpschoedel, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Checks the DomKey in the non-printable map to determine whether a key event is non-character. And fallback to check the character value. BUG=633238 Committed: https://crrev.com/958f9a87ed3bf08d72839ce1e078f967ff4dabd6 Cr-Commit-Position: refs/heads/master@{#434412}

Patch Set 1 #

Patch Set 2 : Checks the DomKey in the non-printable map to determine whether a key event is non-character. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 2 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
Shu Chen
Can you please review this cl? Thanks.
4 years, 1 month ago (2016-11-10 06:47:38 UTC) #6
kpschoedel
LGTM. Sorry for the delay; it took me a while to get a good build ...
4 years ago (2016-11-23 15:28:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413006/1
4 years ago (2016-11-24 00:23:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 02:25:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413006/1
4 years ago (2016-11-24 02:33:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413006/20001
4 years ago (2016-11-24 03:36:43 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-24 05:37:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413006/20001
4 years ago (2016-11-24 08:55:55 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 10:56:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481413006/20001
4 years ago (2016-11-25 00:05:29 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 00:25:36 UTC) #26
commit-bot: I haz the power
4 years ago (2016-11-25 00:27:37 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/958f9a87ed3bf08d72839ce1e078f967ff4dabd6
Cr-Commit-Position: refs/heads/master@{#434412}

Powered by Google App Engine
This is Rietveld 408576698