Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(336)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/api_test/messaging/on_unload/manifest.json
Issue
2481413004
:
[Extensions] Make port creation synchronous in unload handlers (Closed)
Patch Set: Ilya's
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/extension_messages_apitest.cc
chrome/browser/renderer_host/chrome_extension_message_filter.h
chrome/browser/renderer_host/chrome_extension_message_filter.cc
chrome/test/data/extensions/api_test/messaging/on_unload/content_script.js
chrome/test/data/extensions/api_test/messaging/on_unload/manifest.json
chrome/test/data/extensions/api_test/messaging/on_unload/test.js
extensions/common/extension_messages.h
extensions/renderer/extension_frame_helper.h
extensions/renderer/extension_frame_helper.cc
extensions/renderer/messaging_bindings.h
extensions/renderer/messaging_bindings.cc
third_party/WebKit/Source/web/WebDocument.cpp
third_party/WebKit/public/web/WebDocument.h
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/data/extensions/api_test/messaging/on_unload/content_script.js
('k') |
chrome/test/data/extensions/api_test/messaging/on_unload/test.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"name": "send message on unload",
3
"version": "1.0",
4
"manifest_version": 2,
5
"description": "Sends a message on tab unload",
6
"background": {
7
"persistent": true,
8
"scripts": ["test.js"]
9
},
10
"content_scripts": [{
11
"matches": ["*://*/*"],
12
"js": ["content_script.js"]
13
}]
14
}
OLD
NEW
« no previous file with comments
|
« chrome/test/data/extensions/api_test/messaging/on_unload/content_script.js
('k') |
chrome/test/data/extensions/api_test/messaging/on_unload/test.js »
('j') |
no next file with comments »
Issue 2481413004: [Extensions] Make port creation synchronous in unload handlers (Closed)
Created 4 years, 1 month ago by Devlin
Modified 4 years, 1 month ago
Reviewers: dcheng, lazyboy, Ilya Sherman
Base URL:
Comments: 11
This is Rietveld
408576698
Chromium Code Reviews
Issue 2481413004:
[Extensions] Make port creation synchronous in unload handlers (Closed)
