Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

Issue 2481393002: [background-sync] Remove WebSyncError and SyncCallbacks (Closed)
Patch Set: Remove stray SyncError declaration Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/SyncError.cpp ('k') | third_party/WebKit/public/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
diff --git a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
index a0eb70a7e1a1a2f1b28d230cfdecf28518aaeaf6..5215bc3f595f2216503fba38dbc36e5024f63cdf 100644
--- a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
+++ b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
@@ -12,7 +12,6 @@
#include "core/dom/ExceptionCode.h"
#include "core/dom/ExecutionContext.h"
#include "modules/background_sync/BackgroundSyncProvider.h"
-#include "modules/background_sync/SyncCallbacks.h"
#include "modules/serviceworkers/ServiceWorkerRegistration.h"
#include "public/platform/Platform.h"
#include "wtf/PtrUtil.h"
@@ -54,8 +53,7 @@ ScriptPromise SyncManager::registerFunction(ScriptState* scriptState,
blink::mojom::BackgroundSyncNetworkState::ONLINE;
backgroundSyncProvider()->registerBackgroundSync(
- std::move(syncRegistration), m_registration->webRegistration(),
- makeUnique<SyncRegistrationCallbacks>(resolver, m_registration));
+ std::move(syncRegistration), m_registration->webRegistration(), resolver);
return promise;
}
@@ -64,9 +62,8 @@ ScriptPromise SyncManager::getTags(ScriptState* scriptState) {
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
- backgroundSyncProvider()->getRegistrations(
- m_registration->webRegistration(),
- makeUnique<SyncGetRegistrationsCallbacks>(resolver, m_registration));
+ backgroundSyncProvider()->getRegistrations(m_registration->webRegistration(),
+ resolver);
return promise;
}
« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/SyncError.cpp ('k') | third_party/WebKit/public/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698