Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h

Issue 2481393002: [background-sync] Remove WebSyncError and SyncCallbacks (Closed)
Patch Set: Code review changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h
diff --git a/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h b/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h
index af633217d1cf1a053375f3677dd977afc007880c..f54c18017a50e6d74fc1865e578f4fee9d76f843 100644
--- a/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h
+++ b/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h
@@ -5,13 +5,13 @@
#ifndef BackgroundSyncProvider_h
#define BackgroundSyncProvider_h
-#include "modules/background_sync/SyncCallbacks.h"
#include "public/platform/modules/background_sync/background_sync.mojom-blink.h"
#include "wtf/Noncopyable.h"
-#include <memory>
namespace blink {
+class ScriptPromiseResolver;
+class SyncError;
iclelland 2016/11/18 20:53:46 blink::SyncError isn't used in this file; do you n
adithyas 2016/11/21 15:25:17 Don't need it, removed :)
class WebServiceWorkerRegistration;
// The BackgroundSyncProvider is called by the SyncManager and SyncRegistration
@@ -28,18 +28,16 @@ class BackgroundSyncProvider {
void registerBackgroundSync(mojom::blink::SyncRegistrationPtr options,
WebServiceWorkerRegistration*,
- std::unique_ptr<SyncRegistrationCallbacks>);
- void getRegistrations(WebServiceWorkerRegistration*,
- std::unique_ptr<SyncGetRegistrationsCallbacks>);
+ ScriptPromiseResolver*);
+ void getRegistrations(WebServiceWorkerRegistration*, ScriptPromiseResolver*);
private:
// Callback handlers
- static void registerCallback(
- std::unique_ptr<blink::SyncRegistrationCallbacks>,
- mojom::blink::BackgroundSyncError,
- mojom::blink::SyncRegistrationPtr options);
+ static void registerCallback(ScriptPromiseResolver*,
+ mojom::blink::BackgroundSyncError,
+ mojom::blink::SyncRegistrationPtr options);
static void getRegistrationsCallback(
- std::unique_ptr<SyncGetRegistrationsCallbacks>,
+ ScriptPromiseResolver*,
mojom::blink::BackgroundSyncError,
mojo::WTFArray<mojom::blink::SyncRegistrationPtr> registrations);

Powered by Google App Engine
This is Rietveld 408576698