[background-sync] Remove WebSyncError and SyncCallbacks

third_party/WebKit/Source/modules/background_sync/SyncError.h

Index: third_party/WebKit/Source/modules/background_sync/SyncError.h
diff --git a/third_party/WebKit/Source/modules/background_sync/SyncError.h b/third_party/WebKit/Source/modules/background_sync/SyncError.h
index d0bac744493e9ed2735317f9f0f142c955d948d9..c908f540780d050b8d76c1ee8f82de8b742c52a3 100644
--- a/third_party/WebKit/Source/modules/background_sync/SyncError.h
+++ b/third_party/WebKit/Source/modules/background_sync/SyncError.h
@@ -6,19 +6,28 @@
 #define SyncError_h
 
 #include "core/dom/DOMException.h"
-#include "platform/heap/Handle.h"
-#include "public/platform/modules/background_sync/WebSyncError.h"
-#include "wtf/Allocator.h"
 
 namespace blink {
 
 class ScriptPromiseResolver;
 
 class SyncError {

[jbroman, 2016/11/18 16:53:32]

Is this class still useful? It seems to just be a place to store a string and
enum until we immediately convert to DOMException in the same source file. It
seems to me that the onRegisterError calls could simply be:

case mojom::blink::BackgroundSyncError::STORAGE:
  resolver->reject(DOMException::create(UnknownError, "Background Sync is
disabled."));
  break;

and so on. WDYT?

[adithyas, 2016/11/18 20:05:00]

+1, I'll get rid of it. Now that I look at it again, I don't know why
SyncError::take even needs ScriptPromiseResolver as a parameter.

-  STATIC_ONLY(SyncError);
-
  public:
-  static DOMException* take(ScriptPromiseResolver*, const WebSyncError&);
+  enum ErrorType {
+    ErrorTypeAbort = 0,
+    ErrorTypeNoPermission,
+    ErrorTypeNotFound,
+    ErrorTypePermissionDenied,
+    ErrorTypeUnknown,
+    ErrorTypeLast = ErrorTypeUnknown
+  };
+
+  SyncError(ErrorType, const String&);
+
+  static DOMException* take(ScriptPromiseResolver*, const SyncError&);
+
+  ErrorType m_errorType;
+  String m_message;
 };
 
 }  // namespace blink