net/nqe/network_quality_estimator_test_util.h - Issue 2481373004: NQE: Add default RTT and throughput observations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/nqe/network_quality_estimator_test_util.h

Issue 2481373004: NQE: Add default RTT and throughput observations (Closed)

Patch Set: Rebased, addressed bengr comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/nqe/network_quality_estimator_test_util.h

diff --git a/net/nqe/network_quality_estimator_test_util.h b/net/nqe/network_quality_estimator_test_util.h

index 5ab1fed2c3ac31f902c89d0983cef173ec2890fe..ba6e66fad090943ad8c5a65fcd12f1a79b501108 100644

--- a/net/nqe/network_quality_estimator_test_util.h

+++ b/net/nqe/network_quality_estimator_test_util.h

@@ -37,7 +37,8 @@ class TestNetworkQualityEstimator : public NetworkQualityEstimator {

std::unique_ptr<net::ExternalEstimateProvider> external_estimate_provider,

const std::map<std::string, std::string>& variation_params,

bool allow_local_host_requests_for_tests,

- bool allow_smaller_responses_for_tests);

+ bool allow_smaller_responses_for_tests,

+ bool add_default_platform_observations);

explicit TestNetworkQualityEstimator(

const std::map<std::string, std::string>& variation_params);