Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2481363009: Revert of Compiling an array literal should be context-independent. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Compiling an array literal should be context-independent. (patchset #5 id:80001 of https://codereview.chromium.org/2479123002/ ) Reason for revert: speculative revert to fix https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9646/steps/Mjsunit%20%28flakes%29/logs/debug-scopes Original issue's description: > Compiling an array literal should be context-independent. > > We are removing use of the debugger context. When the debugger triggers > compilation, we may not have a context from which to create a JSArray. > > R=ishell@chromium.org TBR=ishell@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f56685d0640db162a3509c6576987f88945c963f Cr-Commit-Position: refs/heads/master@{#40906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -71 lines) Patch
M src/ast/ast.cc View 3 chunks +18 lines, -22 lines 0 comments Download
M src/elements.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/elements.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D test/inspector/debugger/get-possible-breakpoints-array-literal.js View 1 chunk +0 lines, -12 lines 0 comments Download
D test/inspector/debugger/get-possible-breakpoints-array-literal-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of Compiling an array literal should be context-independent.
4 years, 1 month ago (2016-11-10 17:48:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481363009/1
4 years, 1 month ago (2016-11-10 17:48:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 17:48:18 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f56685d0640db162a3509c6576987f88945c963f
Cr-Commit-Position: refs/heads/master@{#40906}

Powered by Google App Engine
This is Rietveld 408576698