Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2481363007: Update First Paint to include paint of non-default document background color (Closed)

Created:
4 years, 1 month ago by panicker
Modified:
4 years, 1 month ago
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update First Paint to include paint of non-default document background color BUG=663949 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/09f4d43e57110ca3d2d6ed631b0f24e1b3da4881 Cr-Commit-Position: refs/heads/master@{#431473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
panicker
Could you provide feedback on this? Still verifying this change against top sites etc. Kunihiko ...
4 years, 1 month ago (2016-11-10 00:36:03 UTC) #3
chrishtr
lgtm
4 years, 1 month ago (2016-11-11 01:16:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481363007/1
4 years, 1 month ago (2016-11-11 01:17:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 02:50:33 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:56:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09f4d43e57110ca3d2d6ed631b0f24e1b3da4881
Cr-Commit-Position: refs/heads/master@{#431473}

Powered by Google App Engine
This is Rietveld 408576698