Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2481363003: [Sensors] Implement Sensor.onactivate (Closed)

Created:
4 years, 1 month ago by Mikhail
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Implement Sensor.onactivate In the updated Generic Sensor specification [1] 'onactivate' event handler replaces 'onstatechange' event handler. [1] https://w3c.github.io/sensors/#sensor-onactivate BUG=606766 Committed: https://crrev.com/0e39c88f05ff668f6237d334345508f3534b7997 Cr-Commit-Position: refs/heads/master@{#431546}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment from Alex + rebase #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -146 lines) Patch
M third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 2 12 chunks +43 lines, -110 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 1 2 15 chunks +32 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (18 generated)
shalamov
https://codereview.chromium.org/2481363003/diff/1/third_party/WebKit/Source/modules/sensor/Sensor.cpp File third_party/WebKit/Source/modules/sensor/Sensor.cpp (right): https://codereview.chromium.org/2481363003/diff/1/third_party/WebKit/Source/modules/sensor/Sensor.cpp#newcode291 third_party/WebKit/Source/modules/sensor/Sensor.cpp:291: if (m_state == SensorState::ACTIVE && getExecutionContext()) { if (m_state ...
4 years, 1 month ago (2016-11-09 11:17:16 UTC) #7
Mikhail
On 2016/11/09 11:17:16, shalamov wrote: > https://codereview.chromium.org/2481363003/diff/1/third_party/WebKit/Source/modules/sensor/Sensor.cpp > File third_party/WebKit/Source/modules/sensor/Sensor.cpp (right): > > https://codereview.chromium.org/2481363003/diff/1/third_party/WebKit/Source/modules/sensor/Sensor.cpp#newcode291 > ...
4 years, 1 month ago (2016-11-10 12:09:13 UTC) #10
shalamov
On 2016/11/10 12:09:13, Mikhail wrote: > On 2016/11/09 11:17:16, shalamov wrote: > > > https://codereview.chromium.org/2481363003/diff/1/third_party/WebKit/Source/modules/sensor/Sensor.cpp ...
4 years, 1 month ago (2016-11-10 12:43:23 UTC) #11
haraken
Implementation-wise LGTM
4 years, 1 month ago (2016-11-10 13:00:08 UTC) #12
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-10 16:59:16 UTC) #15
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-10 17:00:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481363003/40001
4 years, 1 month ago (2016-11-11 12:05:37 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 12:10:09 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 12:11:48 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e39c88f05ff668f6237d334345508f3534b7997
Cr-Commit-Position: refs/heads/master@{#431546}

Powered by Google App Engine
This is Rietveld 408576698