Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2481353002:
Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor (Closed)
|
Created:
4 years, 1 month ago by xunjieli Modified:
4 years, 1 month ago Reviewers:
kapishnikov CC:
chromium-reviews, cbentzel+watch_chromium.org, mef Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor
When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't
DCHECK on |write_pending_| because the destruction can be due to
cancellation at which point the embedder doesn't care about
pending write.
BUG=662102
Committed: https://crrev.com/196eed536c508fcbff652fa185a1d390c68761cc
Cr-Commit-Position: refs/heads/master@{#430403}
Patch Set 1 : self review #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Fix |write_pending_| in BidirectionalStreamSpdyImpl We should reset |write_pending_| in ResetStream() when |stream_| is being torn down. Resetting |write_pending_| in NotifyError() doesn't cover cancellation case. BUG=662102 ========== to ========== Remove DCHECk(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ==========
Description was changed from ========== Remove DCHECk(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ========== to ========== Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ==========
xunjieli@chromium.org changed reviewers: + kapishnikov@chromium.org
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Andrei, PTAL. Thanks!111111111111111111111
On 2016/11/07 21:27:30, xunjieli wrote: > Andrei, PTAL. Thanks!111111111111111111111 sorry, my keyboard key got stuck ...
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by xunjieli@chromium.org
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ========== to ========== Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 ========== to ========== Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't DCHECK on |write_pending_| because the destruction can be due to cancellation at which point the embedder doesn't care about pending write. BUG=662102 Committed: https://crrev.com/196eed536c508fcbff652fa185a1d390c68761cc Cr-Commit-Position: refs/heads/master@{#430403} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/196eed536c508fcbff652fa185a1d390c68761cc Cr-Commit-Position: refs/heads/master@{#430403} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
