Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248133002: Make IPC::ChannelProxy test check filter events (Closed)

Created:
6 years, 8 months ago by dmichael (off chromium)
Modified:
6 years, 8 months ago
Reviewers:
jdduke (slow), jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make IPC::ChannelProxy test check filter events BUG=364241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265775

Patch Set 1 : #

Patch Set 2 : Fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M ipc/ipc_channel_proxy_unittest.cc View 1 4 chunks +52 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dmichael (off chromium)
I'm planning on moving some responsibilities for calling MessageFilter events in to MessageRouter, so this ...
6 years, 8 months ago (2014-04-22 20:51:24 UTC) #1
jdduke (slow)
lgtm
6 years, 8 months ago (2014-04-22 22:59:15 UTC) #2
jam
lgtm
6 years, 8 months ago (2014-04-22 23:04:46 UTC) #3
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-23 17:46:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/248133002/40001
6 years, 8 months ago (2014-04-23 17:48:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 19:29:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 19:29:57 UTC) #7
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-23 19:48:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/248133002/60001
6 years, 8 months ago (2014-04-23 19:49:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 21:25:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 21:25:27 UTC) #11
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 8 months ago (2014-04-23 21:41:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/248133002/60001
6 years, 8 months ago (2014-04-23 21:42:26 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:54:56 UTC) #14
Message was sent while issue was closed. 
Change committed as 265775

Powered by Google App Engine
This is Rietveld 408576698