Issue 2481323002: Send notifications in the scheduled futures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2481323002: Send notifications in the scheduled futures. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Send notifications in the scheduled futures. Doing this allows code completion to run before notifications, so we get completions faster. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fd3d6047fb7157e34a261a92a9de65b17de3965f

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -10 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View	1	3 chunks	+29 lines, -10 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/computer/new_notifications.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Is this the long-term approach we want to take? If not, please add a TODO ...

4 years, 1 month ago (2016-11-07 19:16:27 UTC) #2

scheglov

4 years, 1 month ago (2016-11-07 20:01:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fd3d6047fb7157e34a261a92a9de65b17de3965f (presubmit successful).