[Sync] Move sync thread ownership to ProfileSyncService.

[Sync] Move sync thread ownership to ProfileSyncService.

BUG=663008
Committed: https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf
Cr-Commit-Position: refs/heads/master@{#430441}

[maxbogue, 2016-11-07 18:50:12]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 19:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:36:56]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-11-07 19:43:02]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org

[maxbogue, 2016-11-07 19:43:02]

Nicolas, PTAL!

[Nicolas Zea, 2016-11-07 20:29:46]

Mostly LG

https://codereview.chromium.org/2481313002/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2481313002/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:925:
std::unique_ptr<base::Thread> sync_thread_;
I think it's worth explaining the lifetime of this thread here (including the
various subtle issues we discussed, for example mentioning that although we do
join on shutdown, http requests have their own cancelation logic).

https://codereview.chromium.org/2481313002/diff/1/components/sync/driver/glue...
File components/sync/driver/glue/sync_backend_registrar_unittest.cc (right):

https://codereview.chromium.org/2481313002/diff/1/components/sync/driver/glue...
components/sync/driver/glue/sync_backend_registrar_unittest.cc:105:
sync_thread_.WaitUntilThreadStarted();
Until "thread started"? Should this be until idle?

[maxbogue, 2016-11-07 23:11:35]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[maxbogue, 2016-11-07 23:12:06]

https://codereview.chromium.org/2481313002/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2481313002/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.h:925:
std::unique_ptr<base::Thread> sync_thread_;
On 2016/11/07 20:29:46, Nicolas Zea wrote:
> I think it's worth explaining the lifetime of this thread here (including the
> various subtle issues we discussed, for example mentioning that although we do
> join on shutdown, http requests have their own cancelation logic).

Done, PTAL!

https://codereview.chromium.org/2481313002/diff/1/components/sync/driver/glue...
File components/sync/driver/glue/sync_backend_registrar_unittest.cc (right):

https://codereview.chromium.org/2481313002/diff/1/components/sync/driver/glue...
components/sync/driver/glue/sync_backend_registrar_unittest.cc:105:
sync_thread_.WaitUntilThreadStarted();
On 2016/11/07 20:29:46, Nicolas Zea wrote:
> Until "thread started"? Should this be until idle?

Whoops, you're right, this is a bad merge from before
http://crrev.com/2471183003. Replaced with FlushForTesting() and removed the
RunLoop() below.

[commit-bot: I haz the power, 2016-11-07 23:12:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:10:06]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2016-11-08 00:25:03]

LGTM, great to see this landing!

[maxbogue, 2016-11-08 00:27:22]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:34:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 00:52:40]

Description was changed from

==========
[Sync] Move sync thread ownership to ProfileSyncService.

BUG=663008
==========

to

==========
[Sync] Move sync thread ownership to ProfileSyncService.

BUG=663008

Committed: https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf
Cr-Commit-Position: refs/heads/master@{#430441}
==========

[commit-bot: I haz the power, 2016-11-08 00:52:41]

Patchset 2 (id:??) landed as
https://crrev.com/71190f64c797987aae80d1e343e46ea6509c7aaf
Cr-Commit-Position: refs/heads/master@{#430441}