Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2481263004: Revert of Remove MediaStreamTrack.getSources(). (Closed)

Created:
4 years, 1 month ago by brianderson
Modified:
4 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, eric.carlson_apple.com, kinuko+watch, Srirama, miu+watch_chromium.org, jam, dglazkov+blink, einbinder+watch-test-runner_chromium.org, blink-reviews, darin-cc_chromium.org, xjz+watch_chromium.org, blink-reviews-api_chromium.org, mcasas+watch+mediastream_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, mcasas+watch+vc_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, avayvod+watch_chromium.org, isheriff+watch_chromium.org, hta - Chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove MediaStreamTrack.getSources(). (patchset #4 id:80001 of https://codereview.chromium.org/2471803002/ ) Reason for revert: Broke some test metrics. See http://crbug.com/662414. Original issue's description: > Remove MediaStreamTrack.getSources(). > > Intent-to-remove thread: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY > > BUG=649710, 388194 > > Committed: https://crrev.com/3ea42b21339ebf028e0ff6e368ca60d463386dd2 > Cr-Commit-Position: refs/heads/master@{#429745} TBR=rbyers@chromium.org,hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=649710, 388194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1108 lines, -18 lines) Patch
M chrome/test/data/extensions/hangout_services_test.html View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/media_access/media_check_guest.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/media_devices.js View 1 chunk +13 lines, -1 line 0 comments Download
M components/test_runner/mock_web_media_stream_center.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 3 chunks +39 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_center.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_center.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 4 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 5 chunks +66 lines, -0 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 6 chunks +55 lines, -0 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +4 lines, -6 lines 0 comments Download
M extensions/test/data/web_view/media_access/check/media_check_guest.html View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSources.html View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSources-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesCallback.h View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesCallback.idl View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.h View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/mediastream/SourceInfo.idl View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaClient.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/exported/WebSourceInfo.cpp View 1 chunk +109 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/mediastream/MediaStreamTrackSourcesRequest.h View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebMediaStreamTrackSourcesRequest.h View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebSourceInfo.h View 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebUserMediaClient.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
brianderson
Created Revert of Remove MediaStreamTrack.getSources().
4 years, 1 month ago (2016-11-08 22:27:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481263004/1
4 years, 1 month ago (2016-11-08 22:28:13 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:33:34 UTC) #5
Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698