Issue 2481263003: [wasm] Mutable globals cannot be exported

Issue 2481263003: [wasm] Mutable globals cannot be exported (Closed)

Created:
4 years, 1 month ago by ahaas

Modified:
4 years, 1 month ago

Reviewers:
titzer, rossberg

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[wasm] Mutable globals cannot be exported R=titzer@chromium.org, rossberg@chromium.org TEST=unittests/WasmModuleVerifyTest.ExportMutableGlobal Committed: https://crrev.com/9604b06e26fe6e9b89279f1f95b9ce02c9823354 Cr-Commit-Position: refs/heads/master@{#40838}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
	M	src/wasm/module-decoder.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	test/unittests/wasm/module-decoder-unittest.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481263003/1

4 years, 1 month ago (2016-11-08 14:15:41 UTC) #8

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:26:20 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9604b06e26fe6e9b89279f1f95b9ce02c9823354
Cr-Commit-Position: refs/heads/master@{#40838}