Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2481233004: Rename SchemaRegistry::SetReady to SetDomainReady (Closed)

Created:
4 years, 1 month ago by emaxx
Modified:
4 years, 1 month ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SchemaRegistry::SetReady to SetDomainReady This should be a slightly better name, as it breaks the close similarity between the SetReady and IsReady methods, which actually behave differently (the former is per-domain, while the latter considers all domains at once). BUG=644304 Committed: https://crrev.com/e6b3ae59441bede55351b5606f254246645207f0 Cr-Commit-Position: refs/heads/master@{#430683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/policy/schema_registry_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema_registry.h View 1 chunk +5 lines, -4 lines 0 comments Download
M components/policy/core/common/schema_registry.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema_registry_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
emaxx
Hi Thiemo, could you please take a look?
4 years, 1 month ago (2016-11-08 19:13:31 UTC) #5
Thiemo Nagel
LGTM
4 years, 1 month ago (2016-11-08 19:19:20 UTC) #8
emaxx
On 2016/11/08 19:19:20, Thiemo Nagel (slow) wrote: > LGTM Thanks for the quick review!
4 years, 1 month ago (2016-11-08 19:22:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481233004/1
4 years, 1 month ago (2016-11-08 19:23:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 19:29:05 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:39:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6b3ae59441bede55351b5606f254246645207f0
Cr-Commit-Position: refs/heads/master@{#430683}

Powered by Google App Engine
This is Rietveld 408576698