chrome/renderer/net/net_error_page_controller.cc - Issue 248123002: Added histograms to https://codereview.chromium.org/207553008/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 248123002: Added histograms to https://codereview.chromium.org/207553008/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Nico's comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/renderer/net/net_error_helper_core_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/net/net_error_page_controller.h"	5 #include "chrome/renderer/net/net_error_page_controller.h"

6	6

7 #include "base/strings/string_piece.h"	7 #include "base/strings/string_piece.h"

8 #include "chrome/renderer/net/net_error_helper.h"	8 #include "chrome/renderer/net/net_error_helper.h"

9 #include "content/public/renderer/render_frame.h"	9 #include "content/public/renderer/render_frame.h"

10 #include "gin/handle.h"	10 #include "gin/handle.h"

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 NetErrorPageController::~NetErrorPageController() {}	75 NetErrorPageController::~NetErrorPageController() {}

76	76

77 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(	77 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(

78 v8::Isolate* isolate) {	78 v8::Isolate* isolate) {

79 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(	79 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(

80 isolate)	80 isolate)

81 .SetMethod("loadStaleButtonClick",	81 .SetMethod("loadStaleButtonClick",

82 &NetErrorPageController::LoadStaleButtonClick)	82 &NetErrorPageController::LoadStaleButtonClick)

83 .SetMethod("reloadButtonClick",	83 .SetMethod("reloadButtonClick",

84 &NetErrorPageController::ReloadButtonClick)	84 &NetErrorPageController::ReloadButtonClick)

85 .SetMethod("moreButtonClick",	85 .SetMethod("moreButtonClick", &NetErrorPageController::MoreButtonClick);

86 &NetErrorPageController::MoreButtonClick);

87 }	86 }

88	87

89 void NetErrorPageController::OnDestruct() {}	88 void NetErrorPageController::OnDestruct() {}

OLD	NEW