Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/renderer/resources/neterror.js

Issue 248123002: Added histograms to https://codereview.chromium.org/207553008/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Jim's comment. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 function toggleHelpBox() { 5 function toggleHelpBox() {
6 var helpBoxOuter = document.getElementById('help-box-outer'); 6 var helpBoxOuter = document.getElementById('help-box-outer');
7 helpBoxOuter.classList.toggle('hidden'); 7 helpBoxOuter.classList.toggle('hidden');
8 var moreLessButton = document.getElementById('more-less-button'); 8 var moreLessButton = document.getElementById('more-less-button');
9 if (helpBoxOuter.classList.contains('hidden')) { 9 if (helpBoxOuter.classList.contains('hidden')) {
10 moreLessButton.innerText = moreLessButton.moreText; 10 moreLessButton.innerText = moreLessButton.moreText;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 } 71 }
72 } 72 }
73 73
74 function loadStaleButtonClick() { 74 function loadStaleButtonClick() {
75 if (window.errorPageController) { 75 if (window.errorPageController) {
76 errorPageController.loadStaleButtonClick(); 76 errorPageController.loadStaleButtonClick();
77 } 77 }
78 } 78 }
79 79
80 function moreButtonClick() { 80 function moreButtonClick() {
81 if (window.errorPageController) { 81 if (window.errorPageController)
Nico 2014/04/23 19:15:30 This change is inconsistent with loadStaleButtonCl
Randy Smith (Not in Mondays) 2014/04/28 16:35:59 Done.
jar (doing other things) 2014/04/28 17:55:09 FWIW: The change is consistent with existing lines
82 errorPageController.moreButtonClick(); 82 errorPageController.moreButtonClick();
83 }
84 } 83 }
85 84
86 <if expr="is_macosx or is_ios or is_linux or is_android"> 85 <if expr="is_macosx or is_ios or is_linux or is_android">
87 // Re-orders buttons. Used on Mac, Linux, and Android, where reload should go 86 // Re-orders buttons. Used on Mac, Linux, and Android, where reload should go
88 // on the right. 87 // on the right.
89 function swapButtonOrder() { 88 function swapButtonOrder() {
90 var reloadButton = document.getElementById('reload-button'); 89 var reloadButton = document.getElementById('reload-button');
91 var moreLessButton = document.getElementById('more-less-button'); 90 var moreLessButton = document.getElementById('more-less-button');
92 var staleLoadButton = document.getElementById('stale-load-button'); 91 var staleLoadButton = document.getElementById('stale-load-button');
93 reloadButton.parentNode.insertBefore(moreLessButton, reloadButton); 92 reloadButton.parentNode.insertBefore(moreLessButton, reloadButton);
94 reloadButton.parentNode.insertBefore(staleLoadButton, reloadButton) 93 reloadButton.parentNode.insertBefore(staleLoadButton, reloadButton)
95 } 94 }
96 document.addEventListener("DOMContentLoaded", swapButtonOrder); 95 document.addEventListener("DOMContentLoaded", swapButtonOrder);
97 </if> 96 </if>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698