Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2481223002: Revert of Disable LayoutTest input-appearance-range-with-datalist-zoomed.html on Mac (Closed)

Created:
4 years, 1 month ago by xlai (Olivia)
Modified:
4 years, 1 month ago
Reviewers:
perkj_chrome, f(malita)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable LayoutTest input-appearance-range-with-datalist-zoomed.html on Mac (patchset #1 id:1 of https://codereview.chromium.org/2476233002/ ) Reason for revert: This CL is adding duplicate item to TestExpectations such that https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8022 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20%28dbg%29/builds/925 are failing. Original issue's description: > Disable LayoutTest input-appearance-range-with-datalist-zoomed.html on Mac > > +crbug.com/662862 [ Mac ] fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html [ Skip ] > > BUG=662862 > TBR=fmalita@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/edef734a016f919ec329e71aadb0d244214852e0 TBR=fmalita@chromium.org,perkj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
xlai (Olivia)
Created Revert of Disable LayoutTest input-appearance-range-with-datalist-zoomed.html on Mac
4 years, 1 month ago (2016-11-07 15:05:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481223002/1
4 years, 1 month ago (2016-11-07 15:05:46 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 1 month ago (2016-11-07 15:06:32 UTC) #5
f(malita)
Thanks, this should be already reverted as part of https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca.
4 years, 1 month ago (2016-11-07 15:08:43 UTC) #6
xlai (Olivia)
On 2016/11/07 15:08:43, f(malita) wrote: > Thanks, this should be already reverted as part of ...
4 years, 1 month ago (2016-11-07 15:13:06 UTC) #7
f(malita)
On 2016/11/07 15:13:06, xlai (Olivia) wrote: > On 2016/11/07 15:08:43, f(malita) wrote: > > Thanks, ...
4 years, 1 month ago (2016-11-07 15:15:12 UTC) #8
xlai (Olivia)
On 2016/11/07 15:15:12, f(malita) wrote: > On 2016/11/07 15:13:06, xlai (Olivia) wrote: > > On ...
4 years, 1 month ago (2016-11-07 15:24:59 UTC) #9
f(malita)
4 years, 1 month ago (2016-11-07 15:32:14 UTC) #10
On 2016/11/07 15:24:59, xlai (Olivia) wrote:
> On 2016/11/07 15:15:12, f(malita) wrote:
> > On 2016/11/07 15:13:06, xlai (Olivia) wrote:
> > > On 2016/11/07 15:08:43, f(malita) wrote:
> > > > Thanks, this should be already reverted as part of
> > > > https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca.
> > > 
> > > The above patch you've mentioned has nothing to do with TestExpectations.
> > 
> > Sure it does.
> > 
> > > There is already an expectation for 
> > > fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html
> > > and that's why your patch is causing a failure. Can you fix that?
> > 
> > Please sync your tree.
> 
> Nope, the above patch you've mentioned is a different one.

No.  The line you were trying to remove in this CL was removed in
https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca (look at the actual
revision, not the Rietveld issue - it was landed manually):

@@ -1372,8 +1335,6 @@
 crbug.com/624019 [ Mac ]
bluetooth/stopNotifications/gen-gatt-op-disconnect-called-before.html [ Skip ]
 crbug.com/624019 [ Mac ]
bluetooth/stopNotifications/gen-gatt-op-garbage-collection-ran-during-success.html
[ Skip ]
 
-crbug.com/662862 [ Mac ]
fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html [ Skip ]
-

Which is what I said: 

> > > On 2016/11/07 15:08:43, f(malita) wrote:
> > > > Thanks, this should be already reverted as part of
> > > > https://crrev.com/568cf3e90941a42d1e85108417c385537c7d72ca.

Powered by Google App Engine
This is Rietveld 408576698