Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2481213004: Add a "Save log" button to media-internals (Closed)

Created:
4 years, 1 month ago by watk
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a "Save log" button to media-internals This button makes it easier to create bug reports because the user can click this button and upload a single file; they don't have to know which player is relevant. This includes a minor cleanup to delete the unused pastValues member of PlayerInfo. BUG=658445 Committed: https://crrev.com/53d1684227982b9d0abc442738b346c737ae0a4f Cr-Commit-Position: refs/heads/master@{#430451}

Patch Set 1 #

Patch Set 2 : fix in-person comments #

Patch Set 3 : Delete cruft #

Patch Set 4 : I'm failing #

Patch Set 5 : set default style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M content/browser/resources/media/client_renderer.js View 1 9 chunks +30 lines, -4 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/resources/media/player_info.js View 2 chunks +0 lines, -7 lines 0 comments Download
M content/test/data/media/webui/player_info_test.html View 3 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
watk
I added screenshots and a sample log file to the bug
4 years, 1 month ago (2016-11-07 23:30:56 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years, 1 month ago (2016-11-07 23:47:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481213004/80001
4 years, 1 month ago (2016-11-07 23:54:52 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 00:53:37 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:57:53 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/53d1684227982b9d0abc442738b346c737ae0a4f
Cr-Commit-Position: refs/heads/master@{#430451}

Powered by Google App Engine
This is Rietveld 408576698