Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: blimp/client/core/compositor/blimp_compositor.h

Issue 2481213003: Make SurfaceFactory lifetime match frame_sink_id_ registration in BlimpCompositor (Closed)
Patch Set: remove bad DCHECK Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/client/core/compositor/blimp_compositor.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_ 5 #ifndef BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_
6 #define BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_ 6 #define BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 std::unique_ptr<cc::CopyOutputRequest> copy_request); 207 std::unique_ptr<cc::CopyOutputRequest> copy_request);
208 208
209 BlimpCompositorClient* client_; 209 BlimpCompositorClient* client_;
210 210
211 BlimpCompositorDependencies* compositor_dependencies_; 211 BlimpCompositorDependencies* compositor_dependencies_;
212 212
213 cc::FrameSinkId frame_sink_id_; 213 cc::FrameSinkId frame_sink_id_;
214 214
215 std::unique_ptr<cc::LayerTreeHostInProcess> host_; 215 std::unique_ptr<cc::LayerTreeHostInProcess> host_;
216 216
217 // The SurfaceFactory is bound to the lifetime of the |proxy_client_|. When
218 // detached, the surface factory will be destroyed.
219 std::unique_ptr<cc::SurfaceFactory> surface_factory_; 217 std::unique_ptr<cc::SurfaceFactory> surface_factory_;
220 base::WeakPtr<BlimpCompositorFrameSinkProxyClient> proxy_client_; 218 base::WeakPtr<BlimpCompositorFrameSinkProxyClient> proxy_client_;
219 bool bound_to_proxy_;
221 220
222 // Whether or not |host_| has asked for a new CompositorFrameSink. 221 // Whether or not |host_| has asked for a new CompositorFrameSink.
223 bool compositor_frame_sink_request_pending_; 222 bool compositor_frame_sink_request_pending_;
224 223
225 // Data for the current frame. 224 // Data for the current frame.
226 cc::LocalFrameId local_frame_id_; 225 cc::LocalFrameId local_frame_id_;
227 gfx::Size current_surface_size_; 226 gfx::Size current_surface_size_;
228 227
229 base::ThreadChecker thread_checker_; 228 base::ThreadChecker thread_checker_;
230 229
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 272
274 base::WeakPtrFactory<BlimpCompositor> weak_ptr_factory_; 273 base::WeakPtrFactory<BlimpCompositor> weak_ptr_factory_;
275 274
276 DISALLOW_COPY_AND_ASSIGN(BlimpCompositor); 275 DISALLOW_COPY_AND_ASSIGN(BlimpCompositor);
277 }; 276 };
278 277
279 } // namespace client 278 } // namespace client
280 } // namespace blimp 279 } // namespace blimp
281 280
282 #endif // BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_ 281 #endif // BLIMP_CLIENT_CORE_COMPOSITOR_BLIMP_COMPOSITOR_H_
OLDNEW
« no previous file with comments | « no previous file | blimp/client/core/compositor/blimp_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698