Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: src/parsing/preparser.h

Issue 2481163002: Assign unique IDs to FunctionLiterals (Closed)
Patch Set: updates Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/preparser.h
diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h
index 6c05e9e1e08bd6f40c6169b74e5b8f7346eb5cb3..4fc33fa70e98414326b22ca9c3ffc9a64df27cb7 100644
--- a/src/parsing/preparser.h
+++ b/src/parsing/preparser.h
@@ -652,7 +652,7 @@ class PreParserFactory {
FunctionLiteral::ParameterFlag has_duplicate_parameters,
FunctionLiteral::FunctionType function_type,
FunctionLiteral::EagerCompileHint eager_compile_hint, int position,
- bool has_braces) {
+ bool has_braces, int function_literal_id) {
return PreParserExpression::Default();
}
@@ -1070,10 +1070,26 @@ class PreParser : public ParserBase<PreParser> {
int class_token_pos, bool* ok) {}
V8_INLINE void DeclareClassProperty(PreParserIdentifier class_name,
PreParserExpression property,
- ClassInfo* class_info, bool* ok) {}
+ ClassLiteralProperty::Kind kind,
+ bool is_static, bool is_constructor,
+ ClassInfo* class_info, bool* ok) {
+ if (kind == ClassLiteralProperty::FIELD && !is_static && !is_constructor) {
+ class_info->instance_field_initializers->Add(
+ PreParserExpression::Default(), zone());
+ }
+ }
V8_INLINE PreParserExpression RewriteClassLiteral(PreParserIdentifier name,
ClassInfo* class_info,
int pos, bool* ok) {
+ bool has_default_constructor = !class_info->has_seen_constructor;
+ bool has_instance_fields =
+ class_info->instance_field_initializers->length() > 0;
+ // Account for the default constructor.
+ if (has_default_constructor) GetNextFunctionLiteralId();
+ if (allow_harmony_class_fields() && has_instance_fields) {
+ // Account for initializer function.
+ GetNextFunctionLiteralId();
+ }
return PreParserExpression::Default();
}

Powered by Google App Engine
This is Rietveld 408576698