Assign unique IDs to FunctionLiterals

src/parsing/parse-info.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PARSING_PARSE_INFO_H_
 #define V8_PARSING_PARSE_INFO_H_
 
 #include "include/v8.h"
 #include "src/globals.h"
 #include "src/handles.h"
@@ skipping 129 matching lines @@
   }
 
   int start_position() const { return start_position_; }
   void set_start_position(int start_position) {
     start_position_ = start_position;
   }
 
   int end_position() const { return end_position_; }
   void set_end_position(int end_position) { end_position_ = end_position; }
 
+  int function_literal_num() const { return function_literal_num_; }
+  void set_function_literal_num(int function_literal_num) {
+    function_literal_num_ = function_literal_num;
+  }
+
   // Getters for individual compiler hints.
   bool is_declaration() const;
   bool requires_class_field_init() const;
   bool is_class_field_initializer() const;
   FunctionKind function_kind() const;
 
   //--------------------------------------------------------------------------
   // TODO(titzer): these should not be part of ParseInfo.
   //--------------------------------------------------------------------------
   Isolate* isolate() const { return isolate_; }
@@ skipping 60 matching lines @@
   Utf16CharacterStream* character_stream_;
   v8::Extension* extension_;
   ScriptCompiler::CompileOptions compile_options_;
   DeclarationScope* script_scope_;
   UnicodeCache* unicode_cache_;
   uintptr_t stack_limit_;
   uint32_t hash_seed_;
   int compiler_hints_;
   int start_position_;
   int end_position_;
+  int function_literal_num_;

[marja, 2016/11/18 10:48:04]

How about using function_literal_id instead of function_literal_num in all
places? Afaik "num" is mostly used in the context of "number of blobs", e.g.,
num_contexts, num_allocatable_double_registers etc.

[jochen (gone - plz use gerrit), 2016/11/21 08:03:47]

done

 
   // TODO(titzer): Move handles and isolate out of ParseInfo.
   Isolate* isolate_;
   Handle<SharedFunctionInfo> shared_;
   Handle<Script> script_;
   MaybeHandle<ScopeInfo> maybe_outer_scope_info_;
 
   //----------- Inputs+Outputs of parsing and scope analysis -----------------
   ScriptData** cached_data_;  // used if available, populated if requested.
   AstValueFactory* ast_value_factory_;  // used if available, otherwise new.
   const AstRawString* function_name_;
 
   //----------- Output of parsing and scope analysis ------------------------
   FunctionLiteral* literal_;
 
   void SetFlag(Flag f) { flags_ |= f; }
   void SetFlag(Flag f, bool v) { flags_ = v ? flags_ | f : flags_ & ~f; }
   bool GetFlag(Flag f) const { return (flags_ & f) != 0; }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PARSING_PARSE_INFO_H_