Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 248113005: use accessTopLayer instead of (DEPRECATED) getTopDevice (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
caryclark
CC:
chromium-reviews
Visibility:
Public.

Description

use accessTopLayer instead of (DEPRECATED) getTopDevice NOTRY=True the win_chromium_rel failure must be a flake, since my CL only edits mac-only files. the mac gpu failure is unrelated to this CL Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269568

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M skia/ext/skia_utils_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 2 3 chunks +28 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reed1
6 years, 7 months ago (2014-05-08 13:21:59 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-05-08 13:29:20 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-08 16:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/248113005/60001
6 years, 7 months ago (2014-05-08 16:49:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 21:51:39 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-09 12:32:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/248113005/80001
6 years, 7 months ago (2014-05-09 12:37:58 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 16:01:07 UTC) #8
reed1
The CQ bit was unchecked by reed@google.com
6 years, 7 months ago (2014-05-09 16:06:14 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-09 16:06:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/248113005/80001
6 years, 7 months ago (2014-05-09 16:10:47 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 11:58:25 UTC) #12
Message was sent while issue was closed. 
Change committed as 269568

Powered by Google App Engine
This is Rietveld 408576698