content/browser/renderer_host/media/video_capture_host.h - Issue 248113003: Fix for closing the desktop sharing notification bar when the shared window is closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_host.h

Issue 248113003: Fix for closing the desktop sharing notification bar when the shared window is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments and add a test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_manager.cc ('K') | « content/browser/renderer_host/media/media_stream_provider.h ('k') | content/browser/renderer_host/media/video_capture_host.cc » ('j') | content/browser/renderer_host/media/video_capture_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_host.h

diff --git a/content/browser/renderer_host/media/video_capture_host.h b/content/browser/renderer_host/media/video_capture_host.h

index 1094c7a5825087dc17f8936f50074f6f580c3c95..5334b439a2c4a269ddaaea12c03257e513402b08 100644

--- a/content/browser/renderer_host/media/video_capture_host.h

+++ b/content/browser/renderer_host/media/video_capture_host.h

@@ -171,8 +171,10 @@ class CONTENT_EXPORT VideoCaptureHost

void DoEndedOnIOThread(const VideoCaptureControllerID& controller_id);

+ // Delete the controller and notifies the VideoCaptureManager. |on_error| is

mcasas 2014/04/25 17:18:35 s/Delete/Deletes/ "comments should be descriptive

+ // true if this is triggered by VideoCaptureControllerEventHandler::OnError.

void DeleteVideoCaptureControllerOnIOThread(

- const VideoCaptureControllerID& controller_id);

+ const VideoCaptureControllerID& controller_id, bool on_error);

MediaStreamManager* media_stream_manager_;