Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2481113003: Handle dart:html in kernel_impact (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -42 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 8 chunks +58 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 4 chunks +42 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-07 15:31:11 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-07 17:43:34 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-08 08:32:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ea13999deaf38f1bf343496a330edab61471147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698