Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2481103002: [wasm] [asm.js] Don't allow bad return types from a global constant (Closed)

Created:
4 years, 1 month ago by bradnelson
Modified:
4 years, 1 month ago
Reviewers:
aseemgarg, bradn, John
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Don't allow bad return types from a global constant We recently allowed global constants in asm.js validated code. When used in a return statement, these need to be of an allowed type. BUG=660813 R=jpp@chromium.org,aseemgarg@chromium.org Committed: https://crrev.com/3f2db58c8985896e6c452fcececced7ddc357eb8 Cr-Commit-Position: refs/heads/master@{#40850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/mjsunit/asm/regress-660813.js View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
aseemgarg
lgtm
4 years, 1 month ago (2016-11-08 22:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481103002/1
4 years, 1 month ago (2016-11-08 22:35:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 23:31:51 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f2db58c8985896e6c452fcececced7ddc357eb8
Cr-Commit-Position: refs/heads/master@{#40850}

Powered by Google App Engine
This is Rietveld 408576698