content/browser/loader/sync_resource_handler.cc - Issue 2481093003: Introduce ResourceRequesterInfo to abstract the requester of resource request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/sync_resource_handler.cc

Issue 2481093003: Introduce ResourceRequesterInfo to abstract the requester of resource request (Closed)

Patch Set: fix URLLoaderFactoryImplTest/URLLoaderFactoryImplTest.GetFailedResponse2 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/sync_resource_handler.cc

diff --git a/content/browser/loader/sync_resource_handler.cc b/content/browser/loader/sync_resource_handler.cc

index b0475ce0db12d7fb4f02e859102b61002a2bb5bd..21e520b4547ab789a576114ddb7e2f59bbde8177 100644

--- a/content/browser/loader/sync_resource_handler.cc

+++ b/content/browser/loader/sync_resource_handler.cc

@@ -8,7 +8,6 @@

#include "base/logging.h"

#include "content/browser/loader/netlog_observer.h"

#include "content/browser/loader/resource_dispatcher_host_impl.h"

-#include "content/browser/loader/resource_message_filter.h"

#include "content/browser/loader/resource_request_info_impl.h"

#include "content/common/resource_messages.h"

#include "content/public/browser/resource_dispatcher_host_delegate.h"

@@ -63,8 +62,9 @@ bool SyncResourceHandler::OnRequestRedirected(

bool SyncResourceHandler::OnResponseStarted(

ResourceResponse* response,

bool* defer) {

- const ResourceRequestInfoImpl* info = GetRequestInfo();

- if (!info->filter())

+ ResourceRequestInfoImpl* info = GetRequestInfo();

+ DCHECK(info->requester_info()->IsRenderer());

+ if (!info->requester_info()->filter())

return false;

if (rdh_->delegate()) {