Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: content/browser/loader/async_resource_handler_unittest.cc

Issue 2481093003: Introduce ResourceRequesterInfo to abstract the requester of resource request (Closed)
Patch Set: incorporated kinuko's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/async_resource_handler_unittest.cc
diff --git a/content/browser/loader/async_resource_handler_unittest.cc b/content/browser/loader/async_resource_handler_unittest.cc
index 9662afd54b75bb039394a478e6677e270ab806e0..e57ee443323737e1423b22e071c089afad04f827 100644
--- a/content/browser/loader/async_resource_handler_unittest.cc
+++ b/content/browser/loader/async_resource_handler_unittest.cc
@@ -33,7 +33,6 @@
#include "content/public/browser/resource_context.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/common/content_features.h"
-#include "content/public/common/process_type.h"
#include "content/public/common/resource_type.h"
#include "content/public/test/mock_resource_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -92,7 +91,6 @@ class RecordingResourceMessageFilter : public ResourceMessageFilter {
net::URLRequestContext* request_context)
: ResourceMessageFilter(
0,
- PROCESS_TYPE_RENDERER,
nullptr,
nullptr,
nullptr,
@@ -101,6 +99,7 @@ class RecordingResourceMessageFilter : public ResourceMessageFilter {
base::Unretained(this))),
resource_context_(resource_context),
request_context_(request_context) {
+ InitializeOnIOThread();
set_peer_process_for_testing(base::Process::Current());
}
@@ -135,6 +134,8 @@ class RecordingResourceMessageFilter : public ResourceMessageFilter {
std::vector<std::unique_ptr<IPC::Message>> messages_;
};
+} // namespace
mmenke 2016/11/21 19:51:55 Any reason for moving this?
horo 2016/11/22 01:12:07 Done.
+
class AsyncResourceHandlerTest : public ::testing::Test,
public ResourceLoaderDelegate {
protected:
@@ -161,8 +162,7 @@ class AsyncResourceHandlerTest : public ::testing::Test,
filter_ =
new RecordingResourceMessageFilter(resource_context_.get(), &context_);
ResourceRequestInfoImpl* info = new ResourceRequestInfoImpl(
- PROCESS_TYPE_RENDERER, // process_type
- 0, // child_id
+ filter_->requester_info(),
0, // route_id
-1, // frame_tree_node_id
0, // origin_pid
@@ -183,7 +183,6 @@ class AsyncResourceHandlerTest : public ::testing::Test,
blink::WebReferrerPolicyDefault, // referrer_policy
blink::WebPageVisibilityStateVisible, // visibility_state
resource_context_.get(), // context
- filter_->GetWeakPtr(), // filter
false, // report_raw_headers
true, // is_async
false, // is_using_lofi
@@ -305,6 +304,4 @@ TEST_F(AsyncResourceHandlerTest, TwoChunksLengths) {
EXPECT_EQ(32768, encoded_body_length);
}
-} // namespace
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698